Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Issue 1659393003: Revert of Switch the page-capturing machinery to use the new hooks. (Closed)

Created:
4 years, 10 months ago by dglazkov
Modified:
4 years, 10 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, dglazkov+blink, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Switch the page-capturing machinery to use the new hooks. (patchset #16 id:300001 of https://codereview.chromium.org/1398823004/ ) Reason for revert: Caused https://code.google.com/p/chromium/issues/detail?id=583261. Original issue's description: > Switch the page-capturing machinery to use the new hooks. > > This is a timing-changing patch. Here are the details: > > * The page text capture machinery no longer uses archaic timers to determine the best time to grab the text from the the document. Instead, it relies on the MeaningfulLayout signals that are coming from Blink. > > * These signals are keyed off the compositor putting up frames, which has an interesting side effect -- at least on some platforms (CrOS and Linux), this signal will not be issued until document/frame/tab is active, which is perfectly fine for our purposes. > > * As a side comment, we should probably unify our position on whether compositor puts up frames for inactive tabs. > > * As another side comment, this would help simplify the logic in translate bubbles that watches for tab to become active. > > * In many cases, the timing is much shorter than before, especially for smaller pages. This is good (faster!), but also means that some tests had to be tweaked to start listening for language detection notifications a bit earlier. > > * Fundamentally, this is a change in timing, not behavior, so the existing test coverage seemed sufficient. > > * The new plumbing is still incompatible with out-of-process iframes (OOPIF) and will need to be fixed up accordingly. > > BUG=521166 > R=jam,andrewhayden,jochen > > Committed: https://crrev.com/afc918de00a2f2895b4d8eaf3a043e654ba5e8fb > Cr-Commit-Position: refs/heads/master@{#372891} TBR=jochen@chromium.org,andrewhayden@chromium.org,jam@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=521166 Committed: https://crrev.com/7d0ddfc32e7425fb179415319476c9447d785059 Cr-Commit-Position: refs/heads/master@{#373175}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -67 lines) Patch
M chrome/browser/translate/translate_manager_browsertest.cc View 5 chunks +51 lines, -39 lines 0 comments Download
M chrome/browser/ui/views/translate/translate_bubble_view_browsertest.cc View 2 chunks +7 lines, -1 line 0 comments Download
M chrome/renderer/chrome_render_frame_observer.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/renderer/chrome_render_frame_observer.cc View 7 chunks +36 lines, -26 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
dglazkov
Created Revert of Switch the page-capturing machinery to use the new hooks.
4 years, 10 months ago (2016-02-03 04:46:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1659393003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1659393003/1
4 years, 10 months ago (2016-02-03 04:47:04 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-03 04:48:08 UTC) #3
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 04:49:06 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7d0ddfc32e7425fb179415319476c9447d785059
Cr-Commit-Position: refs/heads/master@{#373175}

Powered by Google App Engine
This is Rietveld 408576698