Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(904)

Unified Diff: chrome/browser/ui/views/translate/translate_bubble_view_browsertest.cc

Issue 1659393003: Revert of Switch the page-capturing machinery to use the new hooks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/translate/translate_bubble_view_browsertest.cc
diff --git a/chrome/browser/ui/views/translate/translate_bubble_view_browsertest.cc b/chrome/browser/ui/views/translate/translate_bubble_view_browsertest.cc
index 2ac921244a8cc3e756b822b58fa6def995daca6d..e5ef9a0751d92cad6f92f3703dcef8c7ab285c9c 100644
--- a/chrome/browser/ui/views/translate/translate_bubble_view_browsertest.cc
+++ b/chrome/browser/ui/views/translate/translate_bubble_view_browsertest.cc
@@ -8,7 +8,6 @@
#include "base/macros.h"
#include "base/memory/scoped_ptr.h"
#include "chrome/browser/chrome_notification_types.h"
-#include "chrome/browser/translate/chrome_translate_client.h"
#include "chrome/browser/translate/cld_data_harness.h"
#include "chrome/browser/translate/cld_data_harness_factory.h"
#include "chrome/browser/ui/browser.h"
@@ -102,8 +101,15 @@
EXPECT_EQ(active_index, browser()->tab_strip_model()->active_index());
EXPECT_EQ(2, browser()->tab_strip_model()->count());
+ // Wait until the language is detected.
content::WebContents* web_contents =
browser()->tab_strip_model()->GetWebContentsAt(french_index);
+ content::Source<content::WebContents> source(web_contents);
+ ui_test_utils::WindowedNotificationObserverWithDetails<
+ translate::LanguageDetectionDetails>
+ fr_language_detected_signal(chrome::NOTIFICATION_TAB_LANGUAGE_DETERMINED,
+ source);
+ fr_language_detected_signal.Wait();
// The bubble is not shown because the tab is not activated.
EXPECT_FALSE(TranslateBubbleView::GetCurrentBubble());
« no previous file with comments | « chrome/browser/translate/translate_manager_browsertest.cc ('k') | chrome/renderer/chrome_render_frame_observer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698