Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1659393002: [Android] Do not set charge level when charging devices (Closed)

Created:
4 years, 10 months ago by rnephew (Reviews Here)
Modified:
4 years, 10 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Do not set charge level when charging devices BUG=567786 Committed: https://crrev.com/a77aeb0b3a2d5d08793f88824be3112f8e0cfc64 Cr-Commit-Position: refs/heads/master@{#373255}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -19 lines) Patch
M build/android/devil/android/battery_utils.py View 2 chunks +0 lines, -9 lines 0 comments Download
M build/android/devil/android/battery_utils_test.py View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
rnephew (Reviews Here)
4 years, 10 months ago (2016-02-03 02:28:06 UTC) #2
rnephew (Reviews Here)
4 years, 10 months ago (2016-02-03 02:42:15 UTC) #4
jbudorick
lgtm So how do we resolve the batteries getting stuck?
4 years, 10 months ago (2016-02-03 14:07:29 UTC) #5
rnephew (Reviews Here)
On 2016/02/03 14:07:29, jbudorick wrote: > lgtm > > So how do we resolve the ...
4 years, 10 months ago (2016-02-03 14:49:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1659393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1659393002/1
4 years, 10 months ago (2016-02-03 14:49:11 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/125736) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 10 months ago (2016-02-03 14:58:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1659393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1659393002/1
4 years, 10 months ago (2016-02-03 15:35:39 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/125769) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 10 months ago (2016-02-03 15:43:54 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1659393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1659393002/1
4 years, 10 months ago (2016-02-03 16:15:34 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-03 16:45:40 UTC) #17
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 16:47:11 UTC) #19
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/a77aeb0b3a2d5d08793f88824be3112f8e0cfc64
Cr-Commit-Position: refs/heads/master@{#373255}

Powered by Google App Engine
This is Rietveld 408576698