build/android/devil/android/battery_utils_test.py - Issue 1659393002: [Android] Do not set charge level when charging devices

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/devil/android/battery_utils_test.py

Issue 1659393002: [Android] Do not set charge level when charging devices (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/devil/android/battery_utils_test.py

diff --git a/build/android/devil/android/battery_utils_test.py b/build/android/devil/android/battery_utils_test.py

index 0a8cbdd922529c2e40346cfe6d032d2f2f65246e..734b68d1b20f00ec4de17b1b45a7b07a747c6e28 100755

--- a/build/android/devil/android/battery_utils_test.py

+++ b/build/android/devil/android/battery_utils_test.py

@@ -247,17 +247,7 @@ class BatteryUtilsChargeDevice(BatteryUtilsTest):

def testChargeDeviceToLevel(self):

with self.assertCalls(

(self.call.battery.SetCharging(True)),

- (self.call.device.RunShellCommand(

- ['dumpsys', 'battery', 'set', 'level', '50'],

- check_return=True), []),

- (self.call.device.RunShellCommand(

- ['dumpsys', 'battery', 'reset'], check_return=True), []),

(self.call.battery.GetBatteryInfo(), {'level': '50'}),

- (self.call.device.RunShellCommand(

- ['dumpsys', 'battery', 'set', 'level', '50'],

- check_return=True), []),

- (self.call.device.RunShellCommand(

- ['dumpsys', 'battery', 'reset'], check_return=True), []),

(self.call.battery.GetBatteryInfo(), {'level': '100'})):

self.battery.ChargeDeviceToLevel(95)

« no previous file with comments | « build/android/devil/android/battery_utils.py ('k') | no next file » | no next file with comments »