ash: Explicitly teach various components about ShelfLayoutManager.

ash: Explicitly teach various components about ShelfLayoutManager.

. StatusAreaWidget is created by the ShelfWidget instance. So there's no need
  for StatusAreaWidget to go throug the root window to get at the
  ShelfLayoutManager.
. TrayBackgroundView, AshPopupAlignmentDelegate etc. should get the
  ShelfLayoutManager from their associated StatusAreaWidget.
. OverflowButton is created by the shelf itself. There's no reason to look
  it up from the root-window.

BUG=none

Committed: https://crrev.com/d33c56b9855e28aa28565c0ea39bc70aacabe1b7
Cr-Commit-Position: refs/heads/master@{#373159}

[sadrul, 2016-02-02 23:09:59]

sadrul@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2016-02-03 00:01:42]

LGTM

https://codereview.chromium.org/1659283002/diff/40001/ash/shelf/overflow_bubb...
File ash/shelf/overflow_bubble_view.cc (right):

https://codereview.chromium.org/1659283002/diff/40001/ash/shelf/overflow_bubb...
ash/shelf/overflow_bubble_view.cc:80: ShelfLayoutManager* shelf_layout_manager =
nit: keep GetShelfLayoutManager but makes it implementation like you have here
(as it's called more than once).

https://codereview.chromium.org/1659283002/diff/40001/ash/shelf/overflow_butt...
File ash/shelf/overflow_button.cc (right):

https://codereview.chromium.org/1659283002/diff/40001/ash/shelf/overflow_butt...
ash/shelf/overflow_button.cc:39: : CustomButton(listener), bottom_image_(NULL),
shelf_(shelf) {
nit: nullptr

https://codereview.chromium.org/1659283002/diff/40001/ash/system/web_notifica...
File ash/system/web_notification/ash_popup_alignment_delegate.cc (right):

https://codereview.chromium.org/1659283002/diff/40001/ash/system/web_notifica...
ash/system/web_notification/ash_popup_alignment_delegate.cc:44: if (shelf_)
Remove this conditional as shelf_ is always non-null now (otherwise 37 would
crash).

[sadrul, 2016-02-03 02:07:59]

https://codereview.chromium.org/1659283002/diff/40001/ash/shelf/overflow_bubb...
File ash/shelf/overflow_bubble_view.cc (right):

https://codereview.chromium.org/1659283002/diff/40001/ash/shelf/overflow_bubb...
ash/shelf/overflow_bubble_view.cc:80: ShelfLayoutManager* shelf_layout_manager =
On 2016/02/03 00:01:42, sky wrote:
> nit: keep GetShelfLayoutManager but makes it implementation like you have here
> (as it's called more than once).

Done.

https://codereview.chromium.org/1659283002/diff/40001/ash/shelf/overflow_butt...
File ash/shelf/overflow_button.cc (right):

https://codereview.chromium.org/1659283002/diff/40001/ash/shelf/overflow_butt...
ash/shelf/overflow_button.cc:39: : CustomButton(listener), bottom_image_(NULL),
shelf_(shelf) {
On 2016/02/03 00:01:42, sky wrote:
> nit: nullptr

Done.

https://codereview.chromium.org/1659283002/diff/40001/ash/system/web_notifica...
File ash/system/web_notification/ash_popup_alignment_delegate.cc (right):

https://codereview.chromium.org/1659283002/diff/40001/ash/system/web_notifica...
ash/system/web_notification/ash_popup_alignment_delegate.cc:44: if (shelf_)
On 2016/02/03 00:01:42, sky wrote:
> Remove this conditional as shelf_ is always non-null now (otherwise 37 would
> crash).

Done. (fixed up the rest of the code to not check for non-null shelf_ too)

[sadrul, 2016-02-03 03:29:58]

The CQ bit was checked by sadrul@chromium.org

[sadrul, 2016-02-03 03:29:59]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1659283002/#ps80001
(title: "fix-test")

[commit-bot: I haz the power, 2016-02-03 03:33:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1659283002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1659283002/80001

[commit-bot: I haz the power, 2016-02-03 03:39:42]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-02-03 03:41:03]

Description was changed from

==========
ash: Explicitly teach various components about ShelfLayoutManager.

. StatusAreaWidget is created by the ShelfWidget instance. So there's no need
  for StatusAreaWidget to go throug the root window to get at the
  ShelfLayoutManager.
. TrayBackgroundView, AshPopupAlignmentDelegate etc. should get the
  ShelfLayoutManager from their associated StatusAreaWidget.
. OverflowButton is created by the shelf itself. There's no reason to look
  it up from the root-window.

BUG=none
==========

to

==========
ash: Explicitly teach various components about ShelfLayoutManager.

. StatusAreaWidget is created by the ShelfWidget instance. So there's no need
  for StatusAreaWidget to go throug the root window to get at the
  ShelfLayoutManager.
. TrayBackgroundView, AshPopupAlignmentDelegate etc. should get the
  ShelfLayoutManager from their associated StatusAreaWidget.
. OverflowButton is created by the shelf itself. There's no reason to look
  it up from the root-window.

BUG=none

Committed: https://crrev.com/d33c56b9855e28aa28565c0ea39bc70aacabe1b7
Cr-Commit-Position: refs/heads/master@{#373159}
==========

[commit-bot: I haz the power, 2016-02-03 03:41:04]

Patchset 5 (id:??) landed as
https://crrev.com/d33c56b9855e28aa28565c0ea39bc70aacabe1b7
Cr-Commit-Position: refs/heads/master@{#373159}