chrome/browser/ui/cocoa/last_active_browser_cocoa.cc - Issue 1659203002: Remove HostDesktopType from FindLastActive[WithProfile]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/last_active_browser_cocoa.cc

Issue 1659203002: Remove HostDesktopType from FindLastActive[WithProfile] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: mac adl Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/download/download_ui_controller.cc ('K') | « chrome/browser/ui/cocoa/handoff_active_url_observer.cc ('k') | chrome/browser/ui/content_settings/content_setting_bubble_model_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/last_active_browser_cocoa.cc

diff --git a/chrome/browser/ui/cocoa/last_active_browser_cocoa.cc b/chrome/browser/ui/cocoa/last_active_browser_cocoa.cc

index d0cd33577bd0a1463026a3ffeca80cc4e4b04560..3bece9d14974d55a098984f5e5ee19eefaf4563d 100644

--- a/chrome/browser/ui/cocoa/last_active_browser_cocoa.cc

+++ b/chrome/browser/ui/cocoa/last_active_browser_cocoa.cc

@@ -9,7 +9,7 @@

namespace chrome {

Browser* GetLastActiveBrowser() {

sky 2016/02/02 22:33:10 Can you nuke this function and replace with FindLa

scottmg 2016/02/02 23:08:43 The header says it's needed to interface with Obj-

- return FindLastActiveWithHostDesktopType(HOST_DESKTOP_TYPE_NATIVE);

+ return FindLastActive();

}

} // namespace chrome