Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 1659043002: Add an R script that does some statistical tests on benchmark results (Closed)

Created:
4 years, 10 months ago by sigurds
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com, machenbach
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[benchmarks] Add R script for statistical tests on benchmark results NOTRY=true Committed: https://crrev.com/4094d6b567de3cc316821a6374445a7f51f09635 Cr-Commit-Position: refs/heads/master@{#33769}

Patch Set 1 #

Patch Set 2 : Add copyright header #

Patch Set 3 : Format to 80 chars per lines #

Total comments: 2

Patch Set 4 : Moved script #

Patch Set 5 : Add example command line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -0 lines) Patch
A tools/perf/statistics-for-json.R View 1 2 3 4 1 chunk +113 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
sigurds
This is the R script I used to evaluate escape analysis. Maybe you want it ...
4 years, 10 months ago (2016-02-02 14:14:29 UTC) #3
Michael Achenbach
Maybe we should start adding more subdirs to tools. Tools itself is quite bloated. E.g. ...
4 years, 10 months ago (2016-02-02 15:53:10 UTC) #5
sigurds
Move it to tools/perf/ and added the short copyright header. https://codereview.chromium.org/1659043002/diff/40001/tools/statistics-for-json.R File tools/statistics-for-json.R (right): https://codereview.chromium.org/1659043002/diff/40001/tools/statistics-for-json.R#newcode1 ...
4 years, 10 months ago (2016-02-02 16:02:02 UTC) #6
Michael Achenbach
lgtm (rubber-stamp). I didn't really review the code - no R-foo. But I'd be fine ...
4 years, 10 months ago (2016-02-05 09:37:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1659043002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1659043002/80001
4 years, 10 months ago (2016-02-05 12:23:56 UTC) #10
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 10 months ago (2016-02-05 12:29:40 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-05 12:30:06 UTC) #14
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/4094d6b567de3cc316821a6374445a7f51f09635
Cr-Commit-Position: refs/heads/master@{#33769}

Powered by Google App Engine
This is Rietveld 408576698