Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 1658673002: Revert of Disabling AppRTC browser test until I can take a closer look. (Closed)

Created:
4 years, 10 months ago by phoglund_chromium
Modified:
4 years, 10 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, tnakamura+watch_chromium.org, phoglund+watch_chromium.org, mcasas+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disabling AppRTC browser test until I can take a closer look. (patchset #1 id:1 of https://codereview.chromium.org/1637853002/ ) Reason for revert: Test should be fixed now Original issue's description: > Disabling AppRTC browser test until I can take a closer look. > > BUG=581283 > TBR=henrika@chromium.org > > Committed: https://crrev.com/53d1639c9801dd514eab66d08980933d95010049 > Cr-Commit-Position: refs/heads/master@{#371498} TBR=henrika@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=581283 Committed: https://crrev.com/314a64c44ea249f772d0129aef58c6b4a4dae420 Cr-Commit-Position: refs/heads/master@{#372678}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
phoglund_chromium
Created Revert of Disabling AppRTC browser test until I can take a closer look.
4 years, 10 months ago (2016-02-01 16:11:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1658673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1658673002/1
4 years, 10 months ago (2016-02-01 16:11:40 UTC) #2
henrika (OOO until Aug 14)
LGTM
4 years, 10 months ago (2016-02-01 16:12:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1658673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1658673002/1
4 years, 10 months ago (2016-02-01 16:33:20 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-01 16:58:10 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-01 16:59:01 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/314a64c44ea249f772d0129aef58c6b4a4dae420
Cr-Commit-Position: refs/heads/master@{#372678}

Powered by Google App Engine
This is Rietveld 408576698