Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc

Issue 1658673002: Revert of Disabling AppRTC browser test until I can take a closer look. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "base/files/file_enumerator.h" 6 #include "base/files/file_enumerator.h"
7 #include "base/path_service.h" 7 #include "base/path_service.h"
8 #include "base/process/launch.h" 8 #include "base/process/launch.h"
9 #include "base/rand_util.h" 9 #include "base/rand_util.h"
10 #include "base/strings/stringprintf.h" 10 #include "base/strings/stringprintf.h"
(...skipping 211 matching lines...) Expand 10 before | Expand all | Expand 10 after
222 firefox_ = base::LaunchProcess(command_line, base::LaunchOptions()); 222 firefox_ = base::LaunchProcess(command_line, base::LaunchOptions());
223 return firefox_.IsValid(); 223 return firefox_.IsValid();
224 } 224 }
225 225
226 private: 226 private:
227 base::Process dev_appserver_; 227 base::Process dev_appserver_;
228 base::Process firefox_; 228 base::Process firefox_;
229 base::Process collider_server_; 229 base::Process collider_server_;
230 }; 230 };
231 231
232 // Broken because of dependency updates: http://crbug.com/581283. 232 IN_PROC_BROWSER_TEST_F(WebRtcApprtcBrowserTest, MANUAL_WorksOnApprtc) {
233 IN_PROC_BROWSER_TEST_F(WebRtcApprtcBrowserTest,
234 DISABLED_MANUAL_WorksOnApprtc) {
235 DetectErrorsInJavaScript(); 233 DetectErrorsInJavaScript();
236 ASSERT_TRUE(LaunchApprtcInstanceOnLocalhost("9999")); 234 ASSERT_TRUE(LaunchApprtcInstanceOnLocalhost("9999"));
237 ASSERT_TRUE(LaunchColliderOnLocalHost("http://localhost:9999", "8089")); 235 ASSERT_TRUE(LaunchColliderOnLocalHost("http://localhost:9999", "8089"));
238 while (!LocalApprtcInstanceIsUp()) 236 while (!LocalApprtcInstanceIsUp())
239 DVLOG(1) << "Waiting for AppRTC to come up..."; 237 DVLOG(1) << "Waiting for AppRTC to come up...";
240 238
241 GURL room_url = GURL("http://localhost:9999/r/some_room" 239 GURL room_url = GURL("http://localhost:9999/r/some_room"
242 "?wshpp=localhost:8089&wstls=false"); 240 "?wshpp=localhost:8089&wstls=false");
243 241
244 // Set up the left tab. 242 // Set up the left tab.
(...skipping 19 matching lines...) Expand all
264 ASSERT_TRUE(WaitForCallToComeUp(left_tab)); 262 ASSERT_TRUE(WaitForCallToComeUp(left_tab));
265 ASSERT_TRUE(WaitForCallToComeUp(right_tab)); 263 ASSERT_TRUE(WaitForCallToComeUp(right_tab));
266 264
267 ASSERT_TRUE(DetectRemoteVideoPlaying(left_tab)); 265 ASSERT_TRUE(DetectRemoteVideoPlaying(left_tab));
268 ASSERT_TRUE(DetectRemoteVideoPlaying(right_tab)); 266 ASSERT_TRUE(DetectRemoteVideoPlaying(right_tab));
269 267
270 chrome::CloseWebContents(browser(), left_tab, false); 268 chrome::CloseWebContents(browser(), left_tab, false);
271 chrome::CloseWebContents(browser(), right_tab, false); 269 chrome::CloseWebContents(browser(), right_tab, false);
272 } 270 }
273 271
274 #if 0 272 #if defined(OS_LINUX)
275 #define MAYBE_MANUAL_FirefoxApprtcInteropTest MANUAL_FirefoxApprtcInteropTest 273 #define MAYBE_MANUAL_FirefoxApprtcInteropTest MANUAL_FirefoxApprtcInteropTest
276 #else 274 #else
277 // Not implemented yet on Windows and Mac. 275 // Not implemented yet on Windows and Mac.
278 // Broken because of dependency updates: http://crbug.com/581283.
279 #define MAYBE_MANUAL_FirefoxApprtcInteropTest DISABLED_MANUAL_FirefoxApprtcInter opTest 276 #define MAYBE_MANUAL_FirefoxApprtcInteropTest DISABLED_MANUAL_FirefoxApprtcInter opTest
280 #endif 277 #endif
281 278
282 IN_PROC_BROWSER_TEST_F(WebRtcApprtcBrowserTest, 279 IN_PROC_BROWSER_TEST_F(WebRtcApprtcBrowserTest,
283 MAYBE_MANUAL_FirefoxApprtcInteropTest) { 280 MAYBE_MANUAL_FirefoxApprtcInteropTest) {
284 DetectErrorsInJavaScript(); 281 DetectErrorsInJavaScript();
285 ASSERT_TRUE(LaunchApprtcInstanceOnLocalhost("9999")); 282 ASSERT_TRUE(LaunchApprtcInstanceOnLocalhost("9999"));
286 ASSERT_TRUE(LaunchColliderOnLocalHost("http://localhost:9999", "8089")); 283 ASSERT_TRUE(LaunchColliderOnLocalHost("http://localhost:9999", "8089"));
287 while (!LocalApprtcInstanceIsUp()) 284 while (!LocalApprtcInstanceIsUp())
288 DVLOG(1) << "Waiting for AppRTC to come up..."; 285 DVLOG(1) << "Waiting for AppRTC to come up...";
(...skipping 10 matching lines...) Expand all
299 InfoBarService::FromWebContents(chrome_tab), InfoBarResponder::ACCEPT); 296 InfoBarService::FromWebContents(chrome_tab), InfoBarResponder::ACCEPT);
300 ui_test_utils::NavigateToURL(browser(), room_url); 297 ui_test_utils::NavigateToURL(browser(), room_url);
301 298
302 ASSERT_TRUE(LaunchFirefoxWithUrl(room_url)); 299 ASSERT_TRUE(LaunchFirefoxWithUrl(room_url));
303 300
304 ASSERT_TRUE(WaitForCallToComeUp(chrome_tab)); 301 ASSERT_TRUE(WaitForCallToComeUp(chrome_tab));
305 302
306 // Ensure Firefox manages to send video our way. 303 // Ensure Firefox manages to send video our way.
307 ASSERT_TRUE(DetectRemoteVideoPlaying(chrome_tab)); 304 ASSERT_TRUE(DetectRemoteVideoPlaying(chrome_tab));
308 } 305 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698