src/IceAssemblerARM32.cpp - Issue 1658423002: Fix nits from CL https://codereview.chromium.org/1661633002.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceAssemblerARM32.cpp

Issue 1658423002: Fix nits from CL https://codereview.chromium.org/1661633002. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceAssemblerARM32.cpp

diff --git a/src/IceAssemblerARM32.cpp b/src/IceAssemblerARM32.cpp

index 31cd466d3a107fa46b8b3e95b5af2cd98eb4791e..2044050216fcfb223d3093e5e07d897c6af17d3c 100644

--- a/src/IceAssemblerARM32.cpp

+++ b/src/IceAssemblerARM32.cpp

@@ -2756,7 +2756,7 @@ void AssemblerARM32::vorrq(const Operand *OpQd, const Operand *OpQm,

// vorr <Qd>, <Qn>, <Qm>

// 111100100D10nnn0ddd00001N1M1mmm0 where Dddd=OpQd, Nnnn=OpQm, and Mmmm=OpQm.

- constexpr const char *Vorrq = "vandq";

+ constexpr const char *Vorrq = "vorrq";

constexpr IValueT VorrqOpcode = B21 | B8 | B4;

constexpr Type ElmtTy = IceType_i8;

emitSIMDqqq(VorrqOpcode, ElmtTy, OpQd, OpQm, OpQn, Vorrq);

« no previous file with comments | « src/DartARM32/assembler_arm.h ('k') | no next file » | no next file with comments »