Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2109)

Unified Diff: chrome/renderer/validation_message_agent.h

Issue 16583005: Some improvement of validation message bubble UI. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: renaming Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/validation_message_agent.h
diff --git a/chrome/renderer/validation_message_agent.h b/chrome/renderer/validation_message_agent.h
index 7113b074a4a3ba04f0c068e14e82df3f8c98bc27..3c10fe16ce941470b90e89a753d5b32733e94d12 100644
--- a/chrome/renderer/validation_message_agent.h
+++ b/chrome/renderer/validation_message_agent.h
@@ -22,11 +22,14 @@ class ValidationMessageAgent : public content::RenderViewObserver,
private:
// WebValidationMessageClient functions:
- virtual void showValidationMessage(const WebKit::WebRect& anchor_in_screen,
+ virtual void showValidationMessage(const WebKit::WebRect& anchor_in_root_view,
const WebKit::WebString& main_text,
const WebKit::WebString& sub_text,
WebKit::WebTextDirection hint) OVERRIDE;
virtual void hideValidationMessage() OVERRIDE;
+ // TOOD(tkent): add OVERRIDE before landing this.
Nico 2013/06/10 14:51:40 do we add OVERRIDE for overriding blink methods? I
tkent 2013/06/11 07:02:43 Yeah, OVERRIDE is optional in a case of implementi
+ virtual void moveValidationMessage(
+ const WebKit::WebRect& anchor_in_root_view);
DISALLOW_COPY_AND_ASSIGN(ValidationMessageAgent);
};

Powered by Google App Engine
This is Rietveld 408576698