Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Side by Side Diff: chrome/renderer/validation_message_agent.h

Issue 16583005: Some improvement of validation message bubble UI. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: renaming Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_RENDERER_VALIDATION_MESSAGE_AGENT_H_ 5 #ifndef CHROME_RENDERER_VALIDATION_MESSAGE_AGENT_H_
6 #define CHROME_RENDERER_VALIDATION_MESSAGE_AGENT_H_ 6 #define CHROME_RENDERER_VALIDATION_MESSAGE_AGENT_H_
7 7
8 #include "content/public/renderer/render_view_observer.h" 8 #include "content/public/renderer/render_view_observer.h"
9 #include "third_party/WebKit/Source/WebKit/chromium/public/WebValidationMessageC lient.h" 9 #include "third_party/WebKit/Source/WebKit/chromium/public/WebValidationMessageC lient.h"
10 10
11 namespace content { 11 namespace content {
12 class RenderView; 12 class RenderView;
13 } 13 }
14 14
15 // An impelemntation of WebKit::WebValidationMessageClient. This dispatches 15 // An impelemntation of WebKit::WebValidationMessageClient. This dispatches
16 // messages to the browser processes. 16 // messages to the browser processes.
17 class ValidationMessageAgent : public content::RenderViewObserver, 17 class ValidationMessageAgent : public content::RenderViewObserver,
18 public WebKit::WebValidationMessageClient { 18 public WebKit::WebValidationMessageClient {
19 public: 19 public:
20 explicit ValidationMessageAgent(content::RenderView* render_view); 20 explicit ValidationMessageAgent(content::RenderView* render_view);
21 virtual ~ValidationMessageAgent(); 21 virtual ~ValidationMessageAgent();
22 22
23 private: 23 private:
24 // WebValidationMessageClient functions: 24 // WebValidationMessageClient functions:
25 virtual void showValidationMessage(const WebKit::WebRect& anchor_in_screen, 25 virtual void showValidationMessage(const WebKit::WebRect& anchor_in_root_view,
26 const WebKit::WebString& main_text, 26 const WebKit::WebString& main_text,
27 const WebKit::WebString& sub_text, 27 const WebKit::WebString& sub_text,
28 WebKit::WebTextDirection hint) OVERRIDE; 28 WebKit::WebTextDirection hint) OVERRIDE;
29 virtual void hideValidationMessage() OVERRIDE; 29 virtual void hideValidationMessage() OVERRIDE;
30 // TOOD(tkent): add OVERRIDE before landing this.
Nico 2013/06/10 14:51:40 do we add OVERRIDE for overriding blink methods? I
tkent 2013/06/11 07:02:43 Yeah, OVERRIDE is optional in a case of implementi
31 virtual void moveValidationMessage(
32 const WebKit::WebRect& anchor_in_root_view);
30 33
31 DISALLOW_COPY_AND_ASSIGN(ValidationMessageAgent); 34 DISALLOW_COPY_AND_ASSIGN(ValidationMessageAgent);
32 }; 35 };
33 36
34 #endif // CHROME_RENDERER_VALIDATION_MESSAGE_AGENT_H_ 37 #endif // CHROME_RENDERER_VALIDATION_MESSAGE_AGENT_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698