Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 16583: Make a valgrind tool in the same vein as the purify one. (Closed)

Created:
11 years, 11 months ago by Elliot Glaysher
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Make a valgrind tool in the same vein as the purify one. Currently supports the following commands: ./chrome_tests.sh --test base ./chrome_tests.sh --test net ./chrome_tests.sh --test ipc ./chrome_tests.sh --test unit The valgrind_*.py files are my first real big chunks of python, so any suggestions would be greatly appreciated.

Patch Set 1 #

Total comments: 40

Patch Set 2 : Fixes to Erik's comments. #

Patch Set 3 : More fixes for Erik. #

Patch Set 4 : s/generate_mode/generate_suppressions/ #

Total comments: 41

Patch Set 5 : Fixes for Pam #

Patch Set 6 : STOP! Grammar time! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+859 lines, -0 lines) Patch
A tools/valgrind/chrome_tests.py View 1 2 3 4 1 chunk +342 lines, -0 lines 0 comments Download
A tools/valgrind/chrome_tests.sh View 1 1 chunk +4 lines, -0 lines 0 comments Download
A tools/valgrind/suppressions.txt View 1 chunk +183 lines, -0 lines 0 comments Download
A tools/valgrind/valgrind_analyze.py View 1 2 3 4 5 1 chunk +176 lines, -0 lines 0 comments Download
A tools/valgrind/valgrind_test.py View 1 2 3 4 1 chunk +154 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Elliot Glaysher
11 years, 11 months ago (2009-01-07 20:59:18 UTC) #1
Erik does not do reviews
For the most part, I'd say the python looks good. Most of my comments are ...
11 years, 11 months ago (2009-01-08 03:26:30 UTC) #2
Pam (message me for reviews)
On 2009/01/08 03:26:30, Erik Kay wrote: > For the most part, I'd say the python ...
11 years, 11 months ago (2009-01-08 18:18:00 UTC) #3
Elliot Glaysher
http://codereview.chromium.org/16583/diff/1/2 File tools/valgrind/chrome_tests.py (right): http://codereview.chromium.org/16583/diff/1/2#newcode1 Line 1: #!/usr/bin/python On 2009/01/08 03:26:30, Erik Kay wrote: > ...
11 years, 11 months ago (2009-01-08 21:00:49 UTC) #4
Erik does not do reviews
LGTM
11 years, 11 months ago (2009-01-08 21:33:33 UTC) #5
Pam (message me for reviews)
http://codereview.chromium.org/16583/diff/17/221 File tools/valgrind/chrome_tests.py (right): http://codereview.chromium.org/16583/diff/17/221#newcode24 Line 24: import platform_utils If this is the module next ...
11 years, 11 months ago (2009-01-08 23:33:23 UTC) #6
Elliot Glaysher
http://codereview.chromium.org/16583/diff/17/221 File tools/valgrind/chrome_tests.py (right): http://codereview.chromium.org/16583/diff/17/221#newcode24 Line 24: import platform_utils On 2009/01/08 23:33:23, Pam wrote: > ...
11 years, 11 months ago (2009-01-09 00:21:35 UTC) #7
Pam (message me for reviews)
LGTM with a TODO and a bug; see below. - Pam http://codereview.chromium.org/16583/diff/17/221 File tools/valgrind/chrome_tests.py (right): ...
11 years, 11 months ago (2009-01-09 00:46:39 UTC) #8
Elliot Glaysher
11 years, 11 months ago (2009-01-09 01:07:45 UTC) #9
> Meanwhile, to be more transparent, does it work to import this as
> layout_package.platform_utils?

It does if I change the PYTHONPATH in the shell script. Done.

Powered by Google App Engine
This is Rietveld 408576698