Issue 17430: [[[This isn't a real review...it's really the diffs between the parent file i...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17430: [[[This isn't a real review...it's really the diffs between the parent file i... (Closed)

Created:
11 years, 11 months ago by Elliot Glaysher

Modified:
9 years, 7 months ago

Reviewers:
Erik does not do reviews

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

[[[This isn't a real review...it's really the diffs between the parent file in http://codereview.chromium.org/16583]]]

Patch Set 1 #

Total comments: 1

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+134 lines, -122 lines)			Patch
	M	tools/purify/chrome_tests.py	View		9 chunks	+134 lines, -122 lines	1 comment	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Erik does not do reviews

11 years, 11 months ago (2009-01-08 21:28:25 UTC) #1

LGTM

http://codereview.chromium.org/17430/diff/1/2
File tools/purify/chrome_tests.py (right):

http://codereview.chromium.org/17430/diff/1/2#newcode75
Line 75: self._data_dir = "."
You probably want to use the mechanism I used here of using the per module test
data directory (although use 'valgrind' rather than 'purify').  This way the
exclusions are tied to module that it's in.  It's not as important now as it was
before when we had DEPS and the data files had to track the module, but it still
feels like the right level of association.

Expand Messages | Collapse Messages