Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1658253002: Serialize constant instance creation of generic classes. (Closed)

Created:
4 years, 10 months ago by scheglov
Modified:
4 years, 10 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Serialize constant instance creation of generic classes. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/c4493869ca19ef9ba6bd35d3d42e1209eb3b7e63

Patch Set 1 #

Patch Set 2 : Remove the special case for unnamed constructors from _getElementReferenceId(). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+199 lines, -9 lines) Patch
M pkg/analyzer/lib/src/summary/summarize_ast.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 1 3 chunks +18 lines, -8 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_common.dart View 1 chunk +179 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 10 months ago (2016-02-02 17:53:04 UTC) #1
Paul Berry
lgtm
4 years, 10 months ago (2016-02-02 18:05:26 UTC) #2
scheglov
4 years, 10 months ago (2016-02-02 18:11:43 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
c4493869ca19ef9ba6bd35d3d42e1209eb3b7e63 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698