pkg/analyzer/lib/src/summary/summarize_ast.dart - Issue 1658253002: Serialize constant instance creation of generic classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/lib/src/summary/summarize_ast.dart

Issue 1658253002: Serialize constant instance creation of generic classes. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Remove the special case for unnamed constructors from _getElementReferenceId(). Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analyzer/lib/src/summary/summarize_ast.dart

diff --git a/pkg/analyzer/lib/src/summary/summarize_ast.dart b/pkg/analyzer/lib/src/summary/summarize_ast.dart

index c43a9b9a3dad2676a090f2fd3c0704402aa62d9e..20d646d1c2b71793c6a4e316cbc2b5e32c7fe8b7 100644

--- a/pkg/analyzer/lib/src/summary/summarize_ast.dart

+++ b/pkg/analyzer/lib/src/summary/summarize_ast.dart

@@ -36,7 +36,8 @@ class _ConstExprSerializer extends AbstractConstExprSerializer {

} else {

String name = constructor.name.name;

int nameRef = visitor.serializeReference(typeBuilder.reference, name);

- return new EntityRefBuilder(reference: nameRef);

+ return new EntityRefBuilder(

+ reference: nameRef, typeArguments: typeBuilder.typeArguments);

}

« no previous file with comments | « no previous file | pkg/analyzer/lib/src/summary/summarize_elements.dart » ('j') | no next file with comments »