Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Issue 165823003: GN: Change gen command syntax, support relative dirs. (Closed)

Created:
6 years, 10 months ago by brettw
Modified:
6 years, 10 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Visibility:
Public.

Description

GN: Change gen command syntax, support relative dirs. This removes the default "gen" command so that "gn" by itself does nothing (it prints a short help message). The "gen" command now takes as an argument the output directory to use, and I removed the --output flag except for the "gyp" command (which will be needed until we update gyp_chromium). Updates the base build file to keep in sync with recent changes. True relative directories are now supported, so that the directories given to the gen command can be relative to the current one. It also supports relative directories for the desc and refs command. This allows you to be in the base directory and say "gn desc :base" and it will resolve the ":base" label relative to the current directory in the source tree. R=dpranke@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252040

Patch Set 1 #

Patch Set 2 : desc #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : Change in build file writing #

Total comments: 6

Patch Set 6 : review comments fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+260 lines, -41 lines) Patch
M base/BUILD.gn View 1 2 3 4 5 1 chunk +0 lines, -2 lines 0 comments Download
M base/files/file_path.h View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M tools/gn/command_args.cc View 1 chunk +3 lines, -1 line 0 comments Download
M tools/gn/command_gen.cc View 1 2 chunks +20 lines, -4 lines 0 comments Download
M tools/gn/command_gyp.cc View 3 chunks +20 lines, -2 lines 0 comments Download
M tools/gn/command_refs.cc View 1 chunk +3 lines, -1 line 0 comments Download
M tools/gn/commands.cc View 1 2 chunks +7 lines, -8 lines 0 comments Download
M tools/gn/filesystem_utils.h View 1 chunk +11 lines, -0 lines 0 comments Download
M tools/gn/filesystem_utils.cc View 1 2 3 4 5 3 chunks +103 lines, -0 lines 0 comments Download
M tools/gn/filesystem_utils_unittest.cc View 1 2 3 1 chunk +49 lines, -0 lines 0 comments Download
M tools/gn/gn_main.cc View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M tools/gn/ninja_build_writer.cc View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M tools/gn/setup.h View 2 chunks +10 lines, -1 line 0 comments Download
M tools/gn/setup.cc View 1 2 3 4 chunks +20 lines, -21 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
brettw
6 years, 10 months ago (2014-02-14 22:20:57 UTC) #1
Dirk Pranke
lgtm. https://codereview.chromium.org/165823003/diff/130002/base/BUILD.gn File base/BUILD.gn (left): https://codereview.chromium.org/165823003/diff/130002/base/BUILD.gn#oldcode676 base/BUILD.gn:676: "win/text_services_message_filter.h", didn't you land this chunk already? https://codereview.chromium.org/165823003/diff/130002/tools/gn/filesystem_utils.cc ...
6 years, 10 months ago (2014-02-18 19:22:35 UTC) #2
brettw
https://codereview.chromium.org/165823003/diff/130002/base/BUILD.gn File base/BUILD.gn (left): https://codereview.chromium.org/165823003/diff/130002/base/BUILD.gn#oldcode676 base/BUILD.gn:676: "win/text_services_message_filter.h", Yeah, I forgot about the branch, though, and ...
6 years, 10 months ago (2014-02-18 20:22:46 UTC) #3
brettw
6 years, 10 months ago (2014-02-19 19:11:22 UTC) #4
Message was sent while issue was closed.
Committed patchset #6 manually as r252040 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698