tools/gn/command_refs.cc - Issue 165823003: GN: Change gen command syntax, support relative dirs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/command_refs.cc

Issue 165823003: GN: Change gen command syntax, support relative dirs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: review comments fixes Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/command_refs.cc

diff --git a/tools/gn/command_refs.cc b/tools/gn/command_refs.cc

index fde617c2d9239bdf45047425cdf2832ca1669fa2..86e12adffda821c81f6b51ae0ccc2d120ef67f04 100644

--- a/tools/gn/command_refs.cc

+++ b/tools/gn/command_refs.cc

@@ -85,7 +85,9 @@ int RunRefs(const std::vector<std::string>& args) {

Setup* setup = new Setup;

setup->set_check_for_bad_items(false);

- if (!setup->DoSetup() || !setup->Run())

+ // TODO(brettw) bug 343726: Use a temporary directory instead of this

+ // default one to avoid messing up any build that's in there.

+ if (!setup->DoSetup("//out/Default/") || !setup->Run())

return 1;

std::vector<const BuilderRecord*> records = setup->builder()->GetAllRecords();

« no previous file with comments | « tools/gn/command_gyp.cc ('k') | tools/gn/commands.cc » ('j') | no next file with comments »