content/browser/web_contents/web_contents_impl.h - Issue 1658003002: Enable range-based for loops to loop over a WebContents' frame hosts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 1658003002: Enable range-based for loops to loop over a WebContents' frame hosts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More stuff. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/web_contents/web_contents_impl.h

diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h

index 0dd3d6cac57623496e4d73ec89352badfe536d37..5c847f80bf77c242c1c307fe8ecb90c93cf87dc5 100644

--- a/content/browser/web_contents/web_contents_impl.h

+++ b/content/browser/web_contents/web_contents_impl.h

@@ -244,6 +244,7 @@ class CONTENT_EXPORT WebContentsImpl

int frame_tree_node_id) override;

void ForEachFrame(

const base::Callback<void(RenderFrameHost*)>& on_frame) override;

+ std::vector<RenderFrameHost*> FrameHosts() override;

ncarter (slow) 2016/02/02 20:54:14 How about GetAllFrames(), to be consistent with Se

dcheng 2016/02/02 21:37:15 Hmm. Would this name still make sense if this retu

int SendToAllFrames(IPC::Message* message) override;

RenderViewHostImpl* GetRenderViewHost() const override;

int GetRoutingID() const override;

« no previous file with comments | « chrome/browser/site_details.cc ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »