Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Side by Side Diff: content/browser/web_contents/web_contents_impl.h

Issue 1658003002: Enable range-based for loops to loop over a WebContents' frame hosts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More stuff. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/site_details.cc ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 5 #ifndef CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
6 #define CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 6 #define CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <map> 10 #include <map>
(...skipping 226 matching lines...) Expand 10 before | Expand all | Expand 10 after
237 const GURL& GetURL() const override; 237 const GURL& GetURL() const override;
238 const GURL& GetVisibleURL() const override; 238 const GURL& GetVisibleURL() const override;
239 const GURL& GetLastCommittedURL() const override; 239 const GURL& GetLastCommittedURL() const override;
240 RenderProcessHost* GetRenderProcessHost() const override; 240 RenderProcessHost* GetRenderProcessHost() const override;
241 RenderFrameHostImpl* GetMainFrame() override; 241 RenderFrameHostImpl* GetMainFrame() override;
242 RenderFrameHostImpl* GetFocusedFrame() override; 242 RenderFrameHostImpl* GetFocusedFrame() override;
243 RenderFrameHostImpl* FindFrameByFrameTreeNodeId( 243 RenderFrameHostImpl* FindFrameByFrameTreeNodeId(
244 int frame_tree_node_id) override; 244 int frame_tree_node_id) override;
245 void ForEachFrame( 245 void ForEachFrame(
246 const base::Callback<void(RenderFrameHost*)>& on_frame) override; 246 const base::Callback<void(RenderFrameHost*)>& on_frame) override;
247 std::vector<RenderFrameHost*> FrameHosts() override;
ncarter (slow) 2016/02/02 20:54:14 How about GetAllFrames(), to be consistent with Se
dcheng 2016/02/02 21:37:15 Hmm. Would this name still make sense if this retu
247 int SendToAllFrames(IPC::Message* message) override; 248 int SendToAllFrames(IPC::Message* message) override;
248 RenderViewHostImpl* GetRenderViewHost() const override; 249 RenderViewHostImpl* GetRenderViewHost() const override;
249 int GetRoutingID() const override; 250 int GetRoutingID() const override;
250 RenderWidgetHostView* GetRenderWidgetHostView() const override; 251 RenderWidgetHostView* GetRenderWidgetHostView() const override;
251 void ClosePage() override; 252 void ClosePage() override;
252 RenderWidgetHostView* GetFullscreenRenderWidgetHostView() const override; 253 RenderWidgetHostView* GetFullscreenRenderWidgetHostView() const override;
253 SkColor GetThemeColor() const override; 254 SkColor GetThemeColor() const override;
254 WebUI* CreateSubframeWebUI(const GURL& url, 255 WebUI* CreateSubframeWebUI(const GURL& url,
255 const std::string& frame_name) override; 256 const std::string& frame_name) override;
256 WebUI* GetWebUI() const override; 257 WebUI* GetWebUI() const override;
(...skipping 1063 matching lines...) Expand 10 before | Expand all | Expand 10 after
1320 // Adds/removes a callback called on creation of each new WebContents. 1321 // Adds/removes a callback called on creation of each new WebContents.
1321 static void AddCreatedCallbackForTesting(const CreatedCallback& callback); 1322 static void AddCreatedCallbackForTesting(const CreatedCallback& callback);
1322 static void RemoveCreatedCallbackForTesting(const CreatedCallback& callback); 1323 static void RemoveCreatedCallbackForTesting(const CreatedCallback& callback);
1323 1324
1324 DISALLOW_COPY_AND_ASSIGN(FriendZone); 1325 DISALLOW_COPY_AND_ASSIGN(FriendZone);
1325 }; 1326 };
1326 1327
1327 } // namespace content 1328 } // namespace content
1328 1329
1329 #endif // CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 1330 #endif // CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
OLDNEW
« no previous file with comments | « chrome/browser/site_details.cc ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698