Enable range-based for loops to loop over a WebContents' frame hosts.

Enable range-based for loops to loop over a WebContents' frame hosts.

BUG=none

Committed: https://crrev.com/afb53e2a76bc72e8f40f80c6d1d3d795d96fd7f3
Cr-Commit-Position: refs/heads/master@{#373477}

[dcheng, 2016-02-02 00:29:38]

dcheng@chromium.org changed reviewers:
+ nick@chromium.org

[dcheng, 2016-02-02 00:29:38]

Meh. This is less work then trying to use pimpl (since NodeIterator is currently
an inner class of FrameTree). Maybe it's worth changing at some point...

There's also enough calls to ForEachFrame() that I didn't feel like trying to
fix them all in this patch. But at least people can start writing something
nicer.

[ncarter (slow), 2016-02-02 20:54:14]

Looks like you need to fix the Android build

https://codereview.chromium.org/1658003002/diff/20001/content/browser/web_con...
File content/browser/web_contents/web_contents_impl.h (right):

https://codereview.chromium.org/1658003002/diff/20001/content/browser/web_con...
content/browser/web_contents/web_contents_impl.h:247:
std::vector<RenderFrameHost*> FrameHosts() override;
How about GetAllFrames(), to be consistent with SendToAllFrames() ?

[dcheng, 2016-02-02 21:37:15]

(Trying blind fixes for Android, because my Linux SSD is rather low on free
space atm)

https://codereview.chromium.org/1658003002/diff/20001/content/browser/web_con...
File content/browser/web_contents/web_contents_impl.h (right):

https://codereview.chromium.org/1658003002/diff/20001/content/browser/web_con...
content/browser/web_contents/web_contents_impl.h:247:
std::vector<RenderFrameHost*> FrameHosts() override;
On 2016/02/02 at 20:54:14, ncarter wrote:
> How about GetAllFrames(), to be consistent with SendToAllFrames() ?

Hmm. Would this name still make sense if this returned a range?

I guess so. Done!

[ncarter (slow), 2016-02-03 18:03:51]

lgtm

https://codereview.chromium.org/1658003002/diff/40001/android_webview/native/...
File android_webview/native/aw_contents.cc (right):

https://codereview.chromium.org/1658003002/diff/40001/android_webview/native/...
android_webview/native/aw_contents.cc:247: }
You've got an extra bracket here.

[dcheng, 2016-02-03 23:00:19]

https://codereview.chromium.org/1658003002/diff/40001/android_webview/native/...
File android_webview/native/aw_contents.cc (right):

https://codereview.chromium.org/1658003002/diff/40001/android_webview/native/...
android_webview/native/aw_contents.cc:247: }
On 2016/02/03 at 18:03:51, ncarter wrote:
> You've got an extra bracket here.

Oops, thanks.

[dcheng, 2016-02-03 23:00:25]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2016-02-03 23:00:25]

The patchset sent to the CQ was uploaded after l-g-t-m from nick@chromium.org
Link to the patchset: https://codereview.chromium.org/1658003002/#ps80001
(title: "Remove extra }")

[commit-bot: I haz the power, 2016-02-03 23:00:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1658003002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1658003002/80001

[commit-bot: I haz the power, 2016-02-03 23:10:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-03 23:10:55]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dcheng, 2016-02-04 03:38:54]

dcheng@chromium.org changed reviewers:
+ boliu@chromium.org, thestig@chromium.org

[dcheng, 2016-02-04 03:38:55]

+boliu for android_webview OWNERS
+thestig for chrome OWNERS

[boliu, 2016-02-04 03:41:15]

lgtm

[Lei Zhang, 2016-02-04 05:08:17]

lgtm

https://codereview.chromium.org/1658003002/diff/80001/chrome/browser/site_det...
File chrome/browser/site_details.cc (right):

https://codereview.chromium.org/1658003002/diff/80001/chrome/browser/site_det...
chrome/browser/site_details.cc:111: // URL but a unique origin.  The origin of
the resource will still
formatting

[dcheng, 2016-02-04 05:59:46]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2016-02-04 05:59:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
thestig@chromium.org, nick@chromium.org, boliu@chromium.org
Link to the patchset: https://codereview.chromium.org/1658003002/#ps100001
(title: "Fix miswrapped comment.")

[commit-bot: I haz the power, 2016-02-04 05:59:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1658003002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1658003002/100001

[dcheng, 2016-02-04 05:59:58]

https://codereview.chromium.org/1658003002/diff/80001/chrome/browser/site_det...
File chrome/browser/site_details.cc (right):

https://codereview.chromium.org/1658003002/diff/80001/chrome/browser/site_det...
chrome/browser/site_details.cc:111: // URL but a unique origin.  The origin of
the resource will still
On 2016/02/04 at 05:08:17, Lei Zhang wrote:
> formatting

Done.

[commit-bot: I haz the power, 2016-02-04 08:11:15]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-02-04 08:13:41]

Description was changed from

==========
Enable range-based for loops to loop over a WebContents' frame hosts.

BUG=none
==========

to

==========
Enable range-based for loops to loop over a WebContents' frame hosts.

BUG=none

Committed: https://crrev.com/afb53e2a76bc72e8f40f80c6d1d3d795d96fd7f3
Cr-Commit-Position: refs/heads/master@{#373477}
==========

[commit-bot: I haz the power, 2016-02-04 08:13:42]

Patchset 6 (id:??) landed as
https://crrev.com/afb53e2a76bc72e8f40f80c6d1d3d795d96fd7f3
Cr-Commit-Position: refs/heads/master@{#373477}