Chromium Code Reviews| Index: chrome/browser/ui/apps/chrome_app_delegate.cc |
| diff --git a/chrome/browser/ui/apps/chrome_app_delegate.cc b/chrome/browser/ui/apps/chrome_app_delegate.cc |
| index aebb117481eb0cef93839a2c1dacea5a9db7cf0d..47d0a097541373c5c85958659969e1f3a992c534 100644 |
| --- a/chrome/browser/ui/apps/chrome_app_delegate.cc |
| +++ b/chrome/browser/ui/apps/chrome_app_delegate.cc |
| @@ -110,8 +110,6 @@ class OpenURLFromTabBasedOnBrowserDefault |
| } |
| } |
| - bool IsOwnedByWorker() override { return true; } |
| - |
| private: |
| scoped_ptr<content::WebContents> source_; |
| const content::OpenURLParams params_; |
| @@ -158,7 +156,8 @@ ChromeAppDelegate::NewWindowContentsDelegate::OpenURLFromTab( |
| check_if_default_browser_worker = |
| new ShellIntegration::DefaultBrowserWorker( |
| new OpenURLFromTabBasedOnBrowserDefault(std::move(owned_source), |
| - params)); |
| + params), |
| + true); |
| // Object lifetime notes: The OpenURLFromTabBasedOnBrowserDefault is owned |
|
grt (UTC plus 2)
2016/02/03 15:39:56
should this have:
check_if_default_browser_wor
Patrick Monette
2016/02/03 23:01:39
The worker here is only used to check the default
|
| // by check_if_default_browser_worker. StartCheckIsDefault() takes lifetime |
| // ownership of check_if_default_browser_worker and will clean up after |