Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2170)

Unified Diff: chrome/browser/notifications/message_center_settings_controller_unittest.cc

Issue 1657913003: Refactor of ProfileInfoCache in c/b/notifications (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix errors Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/message_center_settings_controller_unittest.cc
diff --git a/chrome/browser/notifications/message_center_settings_controller_unittest.cc b/chrome/browser/notifications/message_center_settings_controller_unittest.cc
index f4b05b63115eb3655c680d202884c3bea508bbfc..538c8455f4615e66332c84f8eb2252277224dbc8 100644
--- a/chrome/browser/notifications/message_center_settings_controller_unittest.cc
+++ b/chrome/browser/notifications/message_center_settings_controller_unittest.cc
@@ -51,7 +51,7 @@ class MessageCenterSettingsControllerBaseTest : public testing::Test {
void CreateController() {
controller_.reset(new MessageCenterSettingsController(
- testing_profile_manager_.profile_info_cache()));
+ *testing_profile_manager_.profile_attributes_storage()));
}
void ResetController() {
@@ -131,20 +131,15 @@ TEST_F(MessageCenterSettingsControllerTest, NotifierGroups) {
EXPECT_EQ(controller()->GetNotifierGroupAt(0).name,
base::UTF8ToUTF16("Profile-1"));
- EXPECT_EQ(controller()->GetNotifierGroupAt(0).index, 0u);
-
EXPECT_EQ(controller()->GetNotifierGroupAt(1).name,
base::UTF8ToUTF16("Profile-2"));
- EXPECT_EQ(controller()->GetNotifierGroupAt(1).index, 1u);
EXPECT_EQ(controller()->GetActiveNotifierGroup().name,
base::UTF8ToUTF16("Profile-1"));
- EXPECT_EQ(controller()->GetActiveNotifierGroup().index, 0u);
controller()->SwitchToNotifierGroup(1);
EXPECT_EQ(controller()->GetActiveNotifierGroup().name,
base::UTF8ToUTF16("Profile-2"));
- EXPECT_EQ(controller()->GetActiveNotifierGroup().index, 1u);
controller()->SwitchToNotifierGroup(0);
EXPECT_EQ(controller()->GetActiveNotifierGroup().name,
@@ -160,19 +155,16 @@ TEST_F(MessageCenterSettingsControllerChromeOSTest, NotifierGroups) {
EXPECT_EQ(controller()->GetNotifierGroupAt(0).name,
base::UTF8ToUTF16("Profile-1"));
- EXPECT_EQ(controller()->GetNotifierGroupAt(0).index, 0u);
SwitchActiveUser("Profile-2");
EXPECT_EQ(controller()->GetNotifierGroupCount(), 1u);
EXPECT_EQ(controller()->GetNotifierGroupAt(0).name,
base::UTF8ToUTF16("Profile-2"));
- EXPECT_EQ(controller()->GetNotifierGroupAt(0).index, 1u);
SwitchActiveUser("Profile-1");
EXPECT_EQ(controller()->GetNotifierGroupCount(), 1u);
EXPECT_EQ(controller()->GetNotifierGroupAt(0).name,
base::UTF8ToUTF16("Profile-1"));
- EXPECT_EQ(controller()->GetNotifierGroupAt(0).index, 0u);
}
// TODO(mukai): write a test case to reproduce the actual guest session scenario
// in ChromeOS -- no profiles in the profile_info_cache.

Powered by Google App Engine
This is Rietveld 408576698