Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Unified Diff: ui/message_center/notifier_settings.h

Issue 1657913003: Refactor of ProfileInfoCache in c/b/notifications (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix errors Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/message_center/notifier_settings.h
diff --git a/ui/message_center/notifier_settings.h b/ui/message_center/notifier_settings.h
index 95646afcb390c9d04ddfd256c05991131b044280..43e2032686b6245dc3a61f90e2e541d6da2dc770 100644
--- a/ui/message_center/notifier_settings.h
+++ b/ui/message_center/notifier_settings.h
@@ -8,6 +8,7 @@
#include <stddef.h>
#include <string>
+#include <vector>
dewittj 2016/02/08 18:07:10 nit: I don't think this is used in this header fil
lwchkg 2016/02/08 19:06:43 See line 180 (marked in comment.)
dewittj 2016/02/08 19:11:45 right. Thanks!
#include "base/gtest_prod_util.h"
#include "base/macros.h"
@@ -114,8 +115,7 @@ struct MESSAGE_CENTER_EXPORT Notifier {
struct MESSAGE_CENTER_EXPORT NotifierGroup {
NotifierGroup(const gfx::Image& icon,
const base::string16& name,
- const base::string16& login_info,
- size_t index);
+ const base::string16& login_info);
~NotifierGroup();
// Icon of a notifier group.
@@ -127,10 +127,6 @@ struct MESSAGE_CENTER_EXPORT NotifierGroup {
// More display information about the notifier group.
base::string16 login_info;
- // Unique identifier for the notifier group so that they can be selected in
- // the UI.
- const size_t index;
-
private:
DISALLOW_COPY_AND_ASSIGN(NotifierGroup);
};
@@ -155,7 +151,7 @@ class MESSAGE_CENTER_EXPORT NotifierSettingsObserver {
// for the clients of this module.
class MESSAGE_CENTER_EXPORT NotifierSettingsProvider {
public:
- virtual ~NotifierSettingsProvider() {};
+ virtual ~NotifierSettingsProvider() {}
// Sets the delegate.
virtual void AddObserver(NotifierSettingsObserver* observer) = 0;

Powered by Google App Engine
This is Rietveld 408576698