Issue 1657833002: Subzero: Improve x86-32's implementation of getGprForType().

Issue 1657833002: Subzero: Improve x86-32's implementation of getGprForType(). (Closed)

Created:
4 years, 10 months ago by Jim Stichnoth

Modified:
4 years, 10 months ago

Reviewers:
Eric Holk, Karl, sehr, John

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Subzero: Improve x86-32's implementation of getGprForType(). Replaces the hacky implementation with essentially the less hacky x86-64 implementation, minus the i64 handling. Also does a couple of cleanups on the x86-64 side, including removing special-casing for rbp. BUG= none R=jpp@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=ee1aae820b08055583e6c9be7a3118d1e975a45d

Created: 4 years, 10 months ago

	Unified diffs	Side-by-side diffs	Stats (+54 lines, -48 lines)
M	src/IceTargetLoweringX8632Traits.h	View	2 chunks	+49 lines, -37 lines	0 comments
M	src/IceTargetLoweringX8664Traits.h	View	1 chunk	+4 lines, -8 lines	0 comments
M	src/IceTargetLoweringX86BaseImpl.h	View	1 chunk	+1 line, -3 lines	0 comments

Total messages: 6 (3 generated)

Jim Stichnoth

4 years, 10 months ago (2016-02-02 17:29:25 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ee1aae820b08055583e6c9be7a3118d1e975a45d (presubmit successful).