src/IceTargetLoweringX8664Traits.h - Issue 1657833002: Subzero: Improve x86-32's implementation of getGprForType().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceTargetLoweringX8664Traits.h

Issue 1657833002: Subzero: Improve x86-32's implementation of getGprForType(). (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceTargetLoweringX8664Traits.h

diff --git a/src/IceTargetLoweringX8664Traits.h b/src/IceTargetLoweringX8664Traits.h

index 44316b40f54096ee008512be927a9e19fbc50268..0d2b18de7a1e14782cd6f36d1548bfde1d218c87 100644

--- a/src/IceTargetLoweringX8664Traits.h

+++ b/src/IceTargetLoweringX8664Traits.h

@@ -437,17 +437,13 @@ public:

if (!isGPR) \

return RegisterSet::val; \

assert((is64) || (is32) || (is16) || (is8) || \

- getBaseReg(RegisterSet::val) == RegisterSet::Reg_rsp || \

- getBaseReg(RegisterSet::val) == RegisterSet::Reg_rbp); \

+ getBaseReg(RegisterSet::val) == RegisterSet::Reg_rsp); \

constexpr int32_t FirstGprWithRegNumSize = \

- ((is64) || RegisterSet::val == RegisterSet::Reg_rsp || \

- RegisterSet::val == RegisterSet::Reg_rbp) \

+ ((is64) || RegisterSet::val == RegisterSet::Reg_rsp) \

? RegisterSet::Reg_rax \

- : (((is32) || RegisterSet::val == RegisterSet::Reg_esp || \

- RegisterSet::val == RegisterSet::Reg_ebp) \

+ : (((is32) || RegisterSet::val == RegisterSet::Reg_esp) \

? RegisterSet::Reg_eax \

- : (((is16) || RegisterSet::val == RegisterSet::Reg_sp || \

- RegisterSet::val == RegisterSet::Reg_bp) \

+ : (((is16) || RegisterSet::val == RegisterSet::Reg_sp) \

? RegisterSet::Reg_ax \

: RegisterSet::Reg_al)); \

const int32_t NewRegNum = \

« no previous file with comments | « src/IceTargetLoweringX8632Traits.h ('k') | src/IceTargetLoweringX86BaseImpl.h » ('j') | no next file with comments »