src/frames-inl.h - Issue 16578008: Improved function entry hook coverage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/frames-inl.h

Issue 16578008: Improved function entry hook coverage (Closed) Base URL: https://chromium.googlesource.com/external/v8.git@post_fix

Patch Set: Remove reliance on space->Contains check, which is only valid for V8-allocated memory. Go to unsign… Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/frames-inl.h

diff --git a/src/frames-inl.h b/src/frames-inl.h

old mode 100644

new mode 100755

index 1228ccf18df4c4016884f4d44d7479c0eaf3cbd6..36e68aef992d1dde9713ec13a4c791397779b158

--- a/src/frames-inl.h

+++ b/src/frames-inl.h

@@ -136,6 +136,17 @@ inline Code* StackFrame::GetContainingCode(Isolate* isolate, Address pc) {

}

+inline Address* StackFrame::ResolveReturnAddressLocation(Address* pc_address) {

+ if (return_address_location_resolver_ == NULL) {

+ return pc_address;

+ } else {

+ return reinterpret_cast<Address*>(

+ return_address_location_resolver_(

+ reinterpret_cast<uintptr_t>(pc_address)));

+ }

inline EntryFrame::EntryFrame(StackFrameIterator* iterator)

: StackFrame(iterator) {

}