src/ic.cc - Issue 16578008: Improved function entry hook coverage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic.cc

Issue 16578008: Improved function entry hook coverage (Closed) Base URL: https://chromium.googlesource.com/external/v8.git@post_fix

Patch Set: Remove reliance on space->Contains check, which is only valid for V8-allocated memory. Go to unsign… Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ic.cc

diff --git a/src/ic.cc b/src/ic.cc

old mode 100644

new mode 100755

index 94e8773a165fbc6ae9d9a967ac0b93cb785dbf3d..30c5632eab8d2a0df610bba065f8846d0dbc7d37

--- a/src/ic.cc

+++ b/src/ic.cc

@@ -39,6 +39,7 @@

namespace v8 {

namespace internal {

danno 2013/06/25 18:40:35 Stray whitespace change?

Sigurður Ásgeirsson 2013/06/27 13:06:40 Oops, had some code there earlier, fixed.

#ifdef DEBUG

char IC::TransitionMarkFromState(IC::State state) {

switch (state) {

@@ -144,7 +145,7 @@ IC::IC(FrameDepth depth, Isolate* isolate) : isolate_(isolate) {

ASSERT(fp == frame->fp() && pc_address == frame->pc_address());

#endif

fp_ = fp;

- pc_address_ = pc_address;

+ pc_address_ = StackFrame::ResolveReturnAddressLocation(pc_address);

}