src/frames.cc - Issue 16578008: Improved function entry hook coverage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/frames.cc

Issue 16578008: Improved function entry hook coverage (Closed) Base URL: https://chromium.googlesource.com/external/v8.git@post_fix

Patch Set: WIP: Fix X64 implementation. Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/frames.cc

diff --git a/src/frames.cc b/src/frames.cc

index 53f510849ec0cd3ebb13e4397c1477637d7eebd7..e7d4c18007076529cd0d18a38e28b9000793a95b 100644

--- a/src/frames.cc

+++ b/src/frames.cc

@@ -43,7 +43,7 @@ namespace v8 {

namespace internal {

-static ReturnAddressLocationResolver return_address_location_resolver = NULL;

+ReturnAddressLocationResolver return_address_location_resolver = NULL;

danno 2013/06/13 15:33:44 Shouldn't this also be isolate based now?

Sigurður Ásgeirsson 2013/06/19 20:51:51 Sadly no. The instrumentation and profiler are per

// Resolves pc_address through the resolution address function if one is set.