Improved function entry hook coverage

src/frames.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 25 matching lines @@
 #include "safepoint-table.h"
 #include "scopeinfo.h"
 #include "string-stream.h"
 
 #include "allocation-inl.h"
 
 namespace v8 {
 namespace internal {
 
 
-static ReturnAddressLocationResolver return_address_location_resolver = NULL;
+ReturnAddressLocationResolver return_address_location_resolver = NULL;

[danno, 2013/06/13 15:33:44]

Shouldn't this also be isolate based now?

[Sigurður Ásgeirsson, 2013/06/19 20:51:51]

Sadly no. The instrumentation and profiler are per-process, and when enabled,
the profiler will rewrite all return addresses in the process.

 
 
 // Resolves pc_address through the resolution address function if one is set.
 static inline Address* ResolveReturnAddressLocation(Address* pc_address) {
   if (return_address_location_resolver == NULL) {
     return pc_address;
   } else {
     return reinterpret_cast<Address*>(
         return_address_location_resolver(
             reinterpret_cast<uintptr_t>(pc_address)));
@@ skipping 1557 matching lines @@
   ZoneList<StackFrame*> list(10, zone);
   for (StackFrameIterator it(isolate); !it.done(); it.Advance()) {
     StackFrame* frame = AllocateFrameCopy(it.frame(), zone);
     list.Add(frame, zone);
   }
   return list.ToVector();
 }
 
 
 } }  // namespace v8::internal