Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 1657703002: Add dm to DM_INCLUDES to fix Google3 build. (Closed)

Created:
4 years, 10 months ago by dogben
Modified:
4 years, 10 months ago
Reviewers:
mtklein
CC:
reviews_skia.org, jcgregorio
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add dm to DM_INCLUDES to fix Google3 build. It seems that #including a file in the same directory works without the directory being in INCLUDES, but https://codereview.chromium.org/1631053003 #included DMGpuSupport.h from a test. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1657703002 Committed: https://skia.googlesource.com/skia/+/b1fe8f6f6fbd8380f1b55af382213548c2766b77

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M public.bzl View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
dogben
4 years, 10 months ago (2016-02-01 15:19:55 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1657703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1657703002/1
4 years, 10 months ago (2016-02-01 15:20:30 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-01 15:31:46 UTC) #7
mtklein
lgtm
4 years, 10 months ago (2016-02-01 15:33:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1657703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1657703002/1
4 years, 10 months ago (2016-02-01 17:04:32 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-01 17:05:11 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b1fe8f6f6fbd8380f1b55af382213548c2766b77

Powered by Google App Engine
This is Rietveld 408576698