Add SkImage factory method that forces image to be resolved to a texture.

Add SkImage factory method that forces image to be resolved to a texture.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1631053003

Committed: https://skia.googlesource.com/skia/+/8e74f80ca1bd32581a583e2325daf4b46d892ee5

[bsalomon, 2016-01-26 19:21:54]

Description was changed from

==========
Add factory for creating a texture-backed SkImage from a possibly non-texture
SkImage
==========

to

==========
Add factory for creating a texture-backed SkImage from a possibly non-texture
SkImage
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bsalomon, 2016-01-26 19:36:38]

bsalomon@google.com changed reviewers:
+ reed@google.com

[bsalomon, 2016-01-26 19:36:39]

I want to add a GM but wanted to float this idea. Context:
https://groups.google.com/forum/#!searchin/skia-discuss/How$20to$20move$20SkI...

Also, I think we'll want a more complicated version of this in Chrome.

[reed1, 2016-01-26 20:46:05]

Can we slightly broaden it?

SkImage* newForContxtOrSomeOtherName(GrContext*);

If ctx is not null, it does what yours did. If ctx is null, it returns a
raster-backed (i.e. non-texture-backed) version.

[bsalomon, 2016-01-26 20:47:41]

On 2016/01/26 20:46:05, reed1 wrote:
> Can we slightly broaden it?
> 
> SkImage* newForContxtOrSomeOtherName(GrContext*);
> 
> If ctx is not null, it does what yours did. If ctx is null, it returns a
> raster-backed (i.e. non-texture-backed) version.

sgtm

[bsalomon, 2016-01-26 20:52:14]

On 2016/01/26 20:47:41, bsalomon wrote:
> On 2016/01/26 20:46:05, reed1 wrote:
> > Can we slightly broaden it?
> > 
> > SkImage* newForContxtOrSomeOtherName(GrContext*);
> > 
> > If ctx is not null, it does what yours did. If ctx is null, it returns a
> > raster-backed (i.e. non-texture-backed) version.
> 
> sgtm

Does that mean that it is always decoded, rendered, etc to pixels values when
ctx is null?

[reed1, 2016-01-26 20:54:20]

could go either way -- minimalist would be to say that the result is NOT
gpu-backed, but not commit to having decoded things per-se.

[reed1, 2016-01-26 20:55:01]

Or if its easier, we can say something much stronger, like either RASTER or
TEXTURE, and then its clear. Does your use-case care?

[bsalomon, 2016-01-26 21:03:49]

On 2016/01/26 20:55:01, reed1 wrote:
> Or if its easier, we can say something much stronger, like either RASTER or
> TEXTURE, and then its clear. Does your use-case care?

The use case is the client doesn't want to use our texture cache: doesn't want
the cpu-side copy once it's uploaded, doesn't want risk of purge, wants to
control release of the texture by releasing the image and is willing to pay for
the video ram until such time.

One broader way to interpret that is the client doesn't want any caching
behavior and wants the image "ready to draw" without any extra overhead of
resolving to pixels/texels. In that interpretation I'd say always decode or
render.

[bsalomon, 2016-01-26 21:31:23]

Description was changed from

==========
Add factory for creating a texture-backed SkImage from a possibly non-texture
SkImage
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add SkImage factory method that forces image to be resolved to cpu pixels or a
texture.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bsalomon, 2016-01-26 21:33:15]

Here is a version that forces to a cpu memory pixel grid. (Still need to rename
the factory/tests and update the docs)

[bsalomon, 2016-01-26 22:04:18]

On 2016/01/26 21:33:15, bsalomon wrote:
> Here is a version that forces to a cpu memory pixel grid. (Still need to
rename
> the factory/tests and update the docs)

now with renaming/updated docs.

[bsalomon, 2016-01-27 15:34:15]

The CQ bit was checked by bsalomon@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-27 15:34:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1631053003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1631053003/100001

[commit-bot: I haz the power, 2016-01-27 15:35:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-27 15:35:22]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[bsalomon, 2016-01-27 15:37:37]

The CQ bit was checked by bsalomon@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-27 15:37:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1631053003/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1631053003/120001

[commit-bot: I haz the power, 2016-01-27 15:39:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-27 15:39:53]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[bsalomon, 2016-01-27 15:53:39]

The CQ bit was checked by bsalomon@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-27 15:53:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1631053003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1631053003/140001

[commit-bot: I haz the power, 2016-01-27 15:57:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-27 15:57:57]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[bsalomon, 2016-01-28 21:49:00]

Description was changed from

==========
Add SkImage factory method that forces image to be resolved to cpu pixels or a
texture.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add SkImage factory method that forces image to be resolved to a texture.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bsalomon, 2016-01-28 21:49:16]

PTAL, removed raster implementation

[bsalomon, 2016-01-29 16:53:24]

The CQ bit was checked by bsalomon@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-29 16:53:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1631053003/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1631053003/160001

[bsalomon, 2016-01-29 16:53:47]

ping

[commit-bot: I haz the power, 2016-01-29 17:14:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-29 17:14:23]

Dry run: This issue passed the CQ dry run.

[reed1, 2016-01-29 17:19:10]

lgtm w/ request to make the Static function into a method.

https://codereview.chromium.org/1631053003/diff/160001/include/core/SkImage.h
File include/core/SkImage.h (right):

https://codereview.chromium.org/1631053003/diff/160001/include/core/SkImage.h...
include/core/SkImage.h:150: static SkImage* NewTextureImageFromImage(GrContext*,
SkImage*);
nit:

SkImage* newTextureImage(GrContext*) const;

ala newSubset()

[bsalomon, 2016-01-29 19:27:51]

On 2016/01/29 17:19:10, reed1 wrote:
> lgtm w/ request to make the Static function into a method.
> 
> https://codereview.chromium.org/1631053003/diff/160001/include/core/SkImage.h
> File include/core/SkImage.h (right):
> 
>
https://codereview.chromium.org/1631053003/diff/160001/include/core/SkImage.h...
> include/core/SkImage.h:150: static SkImage*
NewTextureImageFromImage(GrContext*,
> SkImage*);
> nit:
> 
> SkImage* newTextureImage(GrContext*) const;
> 
> ala newSubset()

Done

[bsalomon, 2016-01-29 19:28:15]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-01-29 19:28:15]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/1631053003/#ps180001
(title: "static->class method")

[commit-bot: I haz the power, 2016-01-29 19:28:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1631053003/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1631053003/180001

[commit-bot: I haz the power, 2016-01-30 18:01:42]

Description was changed from

==========
Add SkImage factory method that forces image to be resolved to a texture.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add SkImage factory method that forces image to be resolved to a texture.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/8e74f80ca1bd32581a583e2325daf4b46d892ee5
==========

[commit-bot: I haz the power, 2016-01-30 18:01:42]

Committed patchset #10 (id:180001) as
https://skia.googlesource.com/skia/+/8e74f80ca1bd32581a583e2325daf4b46d892ee5