Implement account switcher as action-bar navigation spinner.

Implement account switcher as action-bar navigation spinner.

BUG=338773
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252493

[Lambros, 2014-02-14 02:00:23]

This turned out to be a lot harder than expected.

The styles.xml file is simply for disabling the normal title in the ActionBar
(setting displayOptions=showHome). It could be done programmatically instead,
but that creates a jarring visual effect when the previous title is briefly
visible before being swapped out for the spinner.

The dimens.xml files are for providing different font sizes and adjustments,
based on the screen orientation. There really doesn't seem to be any simpler way
of doing this.

[Sergey Ulanov, 2014-02-18 21:58:43]

https://codereview.chromium.org/165743002/diff/1/remoting/android/java/src/or...
File remoting/android/java/src/org/chromium/chromoting/Chromoting.java (right):

https://codereview.chromium.org/165743002/diff/1/remoting/android/java/src/or...
remoting/android/java/src/org/chromium/chromoting/Chromoting.java:80: boolean
mAlreadyTried;
maybe rename this to make it clear that this has to do with Auth tokens. E.g.
mTriedNewAuthToken.

https://codereview.chromium.org/165743002/diff/1/remoting/remoting_android.gypi
File remoting/remoting_android.gypi (right):

https://codereview.chromium.org/165743002/diff/1/remoting/remoting_android.gy...
remoting/remoting_android.gypi:76: 'resources/styles.xml',
Maybe move these files to files to resource/android/values? It's not right that
strings.xml and styles.xml are not in the same directory as dimens.xml.

https://codereview.chromium.org/165743002/diff/1/remoting/resources/styles.xml
File remoting/resources/styles.xml (right):

https://codereview.chromium.org/165743002/diff/1/remoting/resources/styles.xm...
remoting/resources/styles.xml:1: <?xml version="1.0" encoding="utf-8"?>
This and dimens.xml are android specific. Move to remoting/resources/android?

https://codereview.chromium.org/165743002/diff/1/remoting/resources/values-la...
File remoting/resources/values-land/dimens.xml (right):

https://codereview.chromium.org/165743002/diff/1/remoting/resources/values-la...
remoting/resources/values-land/dimens.xml:1: <?xml version="1.0"
encoding="utf-8"?>
why do we need to use different layout in the landscape mode?

[Lambros, 2014-02-19 22:43:08]

rebase

[Lambros, 2014-02-19 23:51:39]

https://codereview.chromium.org/165743002/diff/1/remoting/android/java/src/or...
File remoting/android/java/src/org/chromium/chromoting/Chromoting.java (right):

https://codereview.chromium.org/165743002/diff/1/remoting/android/java/src/or...
remoting/android/java/src/org/chromium/chromoting/Chromoting.java:80: boolean
mAlreadyTried;
On 2014/02/18 21:58:43, Sergey Ulanov wrote:
> maybe rename this to make it clear that this has to do with Auth tokens. E.g.
> mTriedNewAuthToken.

Done.

https://codereview.chromium.org/165743002/diff/1/remoting/remoting_android.gypi
File remoting/remoting_android.gypi (right):

https://codereview.chromium.org/165743002/diff/1/remoting/remoting_android.gy...
remoting/remoting_android.gypi:76: 'resources/styles.xml',
On 2014/02/18 21:58:43, Sergey Ulanov wrote:
> Maybe move these files to files to resource/android/values? It's not right
that
> strings.xml and styles.xml are not in the same directory as dimens.xml.

Created CL to move these: https://codereview.chromium.org/171533011/
Once that lands, I'll fix this up as well.

https://codereview.chromium.org/165743002/diff/1/remoting/resources/styles.xml
File remoting/resources/styles.xml (right):

https://codereview.chromium.org/165743002/diff/1/remoting/resources/styles.xm...
remoting/resources/styles.xml:1: <?xml version="1.0" encoding="utf-8"?>
On 2014/02/18 21:58:43, Sergey Ulanov wrote:
> This and dimens.xml are android specific. Move to remoting/resources/android?

Will do.

https://codereview.chromium.org/165743002/diff/1/remoting/resources/values-la...
File remoting/resources/values-land/dimens.xml (right):

https://codereview.chromium.org/165743002/diff/1/remoting/resources/values-la...
remoting/resources/values-land/dimens.xml:1: <?xml version="1.0"
encoding="utf-8"?>
On 2014/02/18 21:58:43, Sergey Ulanov wrote:
> why do we need to use different layout in the landscape mode?

On a Nexus 4 or 5, if you rotate it, the action-bar shrinks and crops the
spinner text. So we have to use different sizes and adjustments to get it to
look right in landscape mode.

Adding dimensions to various values-xxx/ folders seems to be the "right" way to
do this, and is consistent with Android itself and various apps.

[Lambros, 2014-02-21 00:42:32]

All the XML resources are in the right places now :)

[Sergey Ulanov, 2014-02-21 01:19:40]

lgtm

[Lambros, 2014-02-21 01:44:50]

The CQ bit was checked by lambroslambrou@chromium.org

[commit-bot: I haz the power, 2014-02-21 01:45:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/lambroslambrou@chromium.org/165743002/...

[commit-bot: I haz the power, 2014-02-21 04:07:07]

Change committed as 252493