remoting/resources/values-land/dimens.xml - Issue 165743002: Implement account switcher as action-bar navigation spinner.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: remoting/resources/values-land/dimens.xml

Issue 165743002: Implement account switcher as action-bar navigation spinner. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>
	Sergey Ulanov 2014/02/18 21:58:43 why do we need to use different layout in the land why do we need to use different layout in the landscape mode? Lambros 2014/02/19 23:51:39 On a Nexus 4 or 5, if you rotate it, the action-ba Show quoted text On 2014/02/18 21:58:43, Sergey Ulanov wrote: > why do we need to use different layout in the landscape mode? On a Nexus 4 or 5, if you rotate it, the action-bar shrinks and crops the spinner text. So we have to use different sizes and adjustments to get it to look right in landscape mode. Adding dimensions to various values-xxx/ folders seems to be the "right" way to do this, and is consistent with Android itself and various apps.
	2

	3 <!-- Copyright 2014 The Chromium Authors. All rights reserved.

	4 Use of this source code is governed by a BSD-style license that can be

	5 found in the LICENSE file.

	6 -->

	7

	8 <resources>

	9 <dimen name="action_bar_title_text_size">16dp</dimen>

	10 <dimen name="action_bar_subtitle_text_size">12dp</dimen>

	11 <dimen name="action_bar_title_top_margin">-4dp</dimen>

	12 <dimen name="action_bar_subtitle_top_margin">-2dp</dimen>

	13 </resources>

OLD	NEW