Add VAND to the integrated ARM assembler.

Add VAND to the integrated ARM assembler.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
R=jpp@chromium.org, stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=fd7975f14884a851379335a07c831fd6f33770f8

[Karl, 2016-02-02 18:12:29]

Description was changed from

==========
Add VAND to the integrated ARM assembler.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
==========

to

==========
Add VAND to the integrated ARM assembler.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
==========

[Karl, 2016-02-02 18:12:29]

kschimpf@google.com changed reviewers:
+ eholk@chromium.org, jpp@chromium.org, sehr@chromium.org, stichnot@chromium.org

[John, 2016-02-02 18:46:28]

lgtm

https://codereview.chromium.org/1657353002/diff/20001/src/IceInstARM32.cpp
File src/IceInstARM32.cpp (right):

https://codereview.chromium.org/1657353002/diff/20001/src/IceInstARM32.cpp#ne...
src/IceInstARM32.cpp:651: case IceType_void:
defaut:?

[Jim Stichnoth, 2016-02-02 18:46:44]

lgtm

https://codereview.chromium.org/1657353002/diff/20001/src/IceInstARM32.cpp
File src/IceInstARM32.cpp (right):

https://codereview.chromium.org/1657353002/diff/20001/src/IceInstARM32.cpp#ne...
src/IceInstARM32.cpp:649: Type DestTy = Dest->getType();
const

or just use "switch (Dest->getType())" like elsewhere.

https://codereview.chromium.org/1657353002/diff/20001/src/IceInstARM32.cpp#ne...
src/IceInstARM32.cpp:662: std::string(typeString(DestTy)));
You're getting enough instances of std::string(typeString(...)) that it may be
time to add a new function in IceTypes.h:

  IceString typeIceString(Type Ty) { return std::string(typeString(Ty)); }

Or, typeString() could be redeclared to return IceString.

https://codereview.chromium.org/1657353002/diff/20001/tests_lit/assembler/arm...
File tests_lit/assembler/arm32/and-vec.ll (right):

https://codereview.chromium.org/1657353002/diff/20001/tests_lit/assembler/arm...
tests_lit/assembler/arm32/and-vec.ll:33: ; IASM-NOT:     vand.i32
Should this just be "vand" like the other changes, instead of "vand.i32"?

[Karl, 2016-02-02 19:25:13]

Description was changed from

==========
Add VAND to the integrated ARM assembler.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
==========

to

==========
Add VAND to the integrated ARM assembler.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
R=jpp@chromium.org, stichnot@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[Karl, 2016-02-02 19:25:14]

Committed patchset #3 (id:40001) manually as
fd7975f14884a851379335a07c831fd6f33770f8 (presubmit successful).

[Karl, 2016-02-02 19:25:38]

https://codereview.chromium.org/1657353002/diff/20001/src/IceInstARM32.cpp
File src/IceInstARM32.cpp (right):

https://codereview.chromium.org/1657353002/diff/20001/src/IceInstARM32.cpp#ne...
src/IceInstARM32.cpp:649: Type DestTy = Dest->getType();
On 2016/02/02 18:46:44, stichnot wrote:
> const
> 
> or just use "switch (Dest->getType())" like elsewhere.

Done.

https://codereview.chromium.org/1657353002/diff/20001/src/IceInstARM32.cpp#ne...
src/IceInstARM32.cpp:651: case IceType_void:
On 2016/02/02 18:46:28, John wrote:
> defaut:?

Done.

https://codereview.chromium.org/1657353002/diff/20001/src/IceInstARM32.cpp#ne...
src/IceInstARM32.cpp:662: std::string(typeString(DestTy)));
On 2016/02/02 18:46:44, stichnot wrote:
> You're getting enough instances of std::string(typeString(...)) that it may be
> time to add a new function in IceTypes.h:
> 
>   IceString typeIceString(Type Ty) { return std::string(typeString(Ty)); }
> 
> Or, typeString() could be redeclared to return IceString.

Done.

https://codereview.chromium.org/1657353002/diff/20001/tests_lit/assembler/arm...
File tests_lit/assembler/arm32/and-vec.ll (right):

https://codereview.chromium.org/1657353002/diff/20001/tests_lit/assembler/arm...
tests_lit/assembler/arm32/and-vec.ll:33: ; IASM-NOT:     vand.i32
On 2016/02/02 18:46:44, stichnot wrote:
> Should this just be "vand" like the other changes, instead of "vand.i32"?

Done.