Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 165723010: Move NullDraw GL bindings and allow them to be disabled temporarily. (Closed)

Created:
6 years, 10 months ago by danakj
Modified:
6 years, 10 months ago
Reviewers:
piman
CC:
chromium-reviews, no sievers
Visibility:
Public.

Description

Move NullDraw GL bindings and allow them to be disabled temporarily. This moves the NullDraw GL bindings out of generate_bindings.py to ui/gl/gl_gl_api_implementation.cc since there are only a few methods and this makes them easier to read, understand, and change. Add to these methods a way to disable them causing drawing to occur. This is needed so that one test in a test suite can disable null draw if it wants pixel output. TBR=piman@chromium.org BUG=270918 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252407

Patch Set 1 #

Patch Set 2 : glnulldraw: #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -55 lines) Patch
M ui/gl/generate_bindings.py View 10 chunks +10 lines, -54 lines 0 comments Download
M ui/gl/gl_bindings.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gl/gl_gl_api_implementation.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gl/gl_gl_api_implementation.cc View 2 chunks +49 lines, -0 lines 0 comments Download
M ui/gl/gl_implementation.h View 1 chunk +13 lines, -1 line 0 comments Download
M ui/gl/gl_implementation.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
danakj
This is split out from https://codereview.chromium.org/145293007/ which previous had a LG on this code, so ...
6 years, 10 months ago (2014-02-20 18:41:50 UTC) #1
danakj
6 years, 10 months ago (2014-02-20 18:42:06 UTC) #2
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 10 months ago (2014-02-20 19:08:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/165723010/30001
6 years, 10 months ago (2014-02-20 19:11:20 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-20 22:52:10 UTC) #5
Message was sent while issue was closed.
Change committed as 252407

Powered by Google App Engine
This is Rietveld 408576698