Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 1657193003: Add FABS intrinsic to the integrated ARM assembler. (Closed)

Created:
4 years, 10 months ago by Karl
Modified:
4 years, 10 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Format. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -3 lines) Patch
M src/DartARM32/assembler_arm.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/DartARM32/assembler_arm.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/IceAssemblerARM32.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/IceAssemblerARM32.cpp View 1 1 chunk +28 lines, -0 lines 0 comments Download
M src/IceInstARM32.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/IceInstARM32.cpp View 1 1 chunk +20 lines, -0 lines 0 comments Download
A tests_lit/assembler/arm32/vabs.ll View 1 chunk +58 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Karl
4 years, 10 months ago (2016-02-02 19:09:21 UTC) #3
Jim Stichnoth
lgtm
4 years, 10 months ago (2016-02-02 20:38:58 UTC) #4
Eric Holk
lgtm
4 years, 10 months ago (2016-02-02 21:18:18 UTC) #5
Karl
4 years, 10 months ago (2016-02-02 21:35:49 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
bd4356d59ef318d8c82f3ef0c879dce147bb3146 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698