Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1656883005: MD Downloads: fix the compiled_resources2.gyp compile (Closed)

Created:
4 years, 10 months ago by Dan Beam
Modified:
4 years, 10 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, michaelpg+watch-polymer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@reentrant-reproduce
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Downloads: fix the compiled_resources2.gyp compile R=dpapad@chromium.org BUG=393873 Committed: https://crrev.com/4bcf7259782f17dbebe292a4e9e799a8043baed9 Cr-Commit-Position: refs/heads/master@{#372871}

Patch Set 1 #

Total comments: 2

Patch Set 2 : merge #

Messages

Total messages: 14 (6 generated)
Dan Beam
4 years, 10 months ago (2016-02-01 23:31:15 UTC) #1
dpapad
lgtm https://codereview.chromium.org/1656883005/diff/1/chrome/browser/resources/md_downloads/manager.js File chrome/browser/resources/md_downloads/manager.js (right): https://codereview.chromium.org/1656883005/diff/1/chrome/browser/resources/md_downloads/manager.js#newcode152 chrome/browser/resources/md_downloads/manager.js:152: var list = /** @type {IronListElement} */(this.$['downloads-list']); !IronListElement
4 years, 10 months ago (2016-02-01 23:33:37 UTC) #2
Dan Beam
https://codereview.chromium.org/1656883005/diff/1/chrome/browser/resources/md_downloads/manager.js File chrome/browser/resources/md_downloads/manager.js (right): https://codereview.chromium.org/1656883005/diff/1/chrome/browser/resources/md_downloads/manager.js#newcode152 chrome/browser/resources/md_downloads/manager.js:152: var list = /** @type {IronListElement} */(this.$['downloads-list']); On 2016/02/01 ...
4 years, 10 months ago (2016-02-01 23:35:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1656883005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1656883005/40001
4 years, 10 months ago (2016-02-02 01:13:51 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/141446)
4 years, 10 months ago (2016-02-02 02:02:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1656883005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1656883005/40001
4 years, 10 months ago (2016-02-02 02:08:18 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 10 months ago (2016-02-02 02:40:51 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-02 02:43:30 UTC) #14
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/4bcf7259782f17dbebe292a4e9e799a8043baed9
Cr-Commit-Position: refs/heads/master@{#372871}

Powered by Google App Engine
This is Rietveld 408576698