Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 1651273002: Polymer: make reproduce.sh re-entrant (Closed)

Created:
4 years, 10 months ago by Dan Beam
Modified:
4 years, 10 months ago
Reviewers:
Jeremy Klein
CC:
chromium-reviews, michaelpg+watch-polymer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Polymer: make reproduce.sh re-entrant This CL allows compiled_resources{,2}.gyp files to exist inside of third_party/polymer/v1_0/components-chromium so we can closure compile this code. Also adds progress notifications while Crisping. R=michaelpg@chromium.org BUG=393873 NOTRY=true Committed: https://crrev.com/3169911a8f59ae808067888750e69d5256311a43 Cr-Commit-Position: refs/heads/master@{#372847}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -12 lines) Patch
M third_party/polymer/v1_0/extract_inline_scripts.sh View 1 3 chunks +5 lines, -10 lines 0 comments Download
M third_party/polymer/v1_0/reproduce.sh View 2 chunks +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
Jeremy Klein
LGTM https://codereview.chromium.org/1651273002/diff/1/third_party/polymer/v1_0/extract_inline_scripts.sh File third_party/polymer/v1_0/extract_inline_scripts.sh (right): https://codereview.chromium.org/1651273002/diff/1/third_party/polymer/v1_0/extract_inline_scripts.sh#newcode13 third_party/polymer/v1_0/extract_inline_scripts.sh:13: echo "Extracts inlines scripts from <src_dir> to <dst_dir>" ...
4 years, 10 months ago (2016-02-01 23:38:29 UTC) #3
Dan Beam
https://codereview.chromium.org/1651273002/diff/1/third_party/polymer/v1_0/extract_inline_scripts.sh File third_party/polymer/v1_0/extract_inline_scripts.sh (right): https://codereview.chromium.org/1651273002/diff/1/third_party/polymer/v1_0/extract_inline_scripts.sh#newcode13 third_party/polymer/v1_0/extract_inline_scripts.sh:13: echo "Extracts inlines scripts from <src_dir> to <dst_dir>" \ ...
4 years, 10 months ago (2016-02-01 23:52:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1651273002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1651273002/20001
4 years, 10 months ago (2016-02-02 00:32:45 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-02 00:59:09 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-02 01:00:02 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3169911a8f59ae808067888750e69d5256311a43
Cr-Commit-Position: refs/heads/master@{#372847}

Powered by Google App Engine
This is Rietveld 408576698