Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 1656833002: Sampler bias for all nofilter flavors (Closed)

Created:
4 years, 10 months ago by f(malita)
Modified:
4 years, 10 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Sampler bias for all nofilter flavors Instead of a piecemeal approach to sampler bias (http://crrev.com/1642273002, http://crrev.com/1539083002), audit all nofilter procs (grep "fInvProc(") and convert them to SkBitmapProcStateAutoMapper. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1656833002 CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot R=reed@google.com Committed: https://skia.googlesource.com/skia/+/eb543071725f465e93ddcc052d54fd5c03f043f9

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -51 lines) Patch
M src/core/SkBitmapProcState.cpp View 1 2 chunks +10 lines, -20 lines 0 comments Download
M src/core/SkBitmapProcState_matrixProcs.cpp View 1 1 chunk +3 lines, -6 lines 0 comments Download
M src/opts/SkBitmapProcState_matrix_neon.h View 1 2 chunks +6 lines, -12 lines 0 comments Download
M src/opts/SkBitmapProcState_opts_SSE2.cpp View 1 2 chunks +6 lines, -13 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
f(malita)
Preemptive change (I assume these are also vulnerable to nofilter rounding / ninepatch alignment issues). ...
4 years, 10 months ago (2016-02-02 17:00:40 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1656833002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1656833002/20001
4 years, 10 months ago (2016-02-02 17:01:04 UTC) #8
reed1
much cleaner. lgtm
4 years, 10 months ago (2016-02-02 17:03:29 UTC) #10
reed1
much cleaner. lgtm
4 years, 10 months ago (2016-02-02 17:03:29 UTC) #11
reed1
much cleaner, lgtm
4 years, 10 months ago (2016-02-02 17:03:46 UTC) #12
reed1
as herb proceeds, we'll have to relate/educate him about these issues, since he is experimenting ...
4 years, 10 months ago (2016-02-02 17:04:31 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1656833002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1656833002/20001
4 years, 10 months ago (2016-02-02 18:15:53 UTC) #15
commit-bot: I haz the power
4 years, 10 months ago (2016-02-02 18:17:32 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/eb543071725f465e93ddcc052d54fd5c03f043f9

Powered by Google App Engine
This is Rietveld 408576698