third_party/WebKit/Source/core/layout/LayoutSlider.cpp - Issue 1656743002: Removing more implicit LayoutUnit construction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutSlider.cpp

Issue 1656743002: Removing more implicit LayoutUnit construction (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix additional test Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutSlider.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutSlider.cpp b/third_party/WebKit/Source/core/layout/LayoutSlider.cpp

index b6d305f479729b991885a282a55b0a0b6df37bf1..de888c90a4d56e5311ff922d922cff0891988ba1 100644

--- a/third_party/WebKit/Source/core/layout/LayoutSlider.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutSlider.cpp

@@ -54,7 +54,7 @@ int LayoutSlider::baselinePosition(FontBaseline, bool /*firstLine*/, LineDirecti

void LayoutSlider::computeIntrinsicLogicalWidths(LayoutUnit& minLogicalWidth, LayoutUnit& maxLogicalWidth) const

{

- maxLogicalWidth = defaultTrackLength * style()->effectiveZoom();

+ maxLogicalWidth = LayoutUnit(defaultTrackLength * style()->effectiveZoom());

if (!style()->width().hasPercent())

minLogicalWidth = maxLogicalWidth;

}