Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 1656603002: Diagnose renderer-side crash with browser-side stack trace. (Closed)

Created:
4 years, 10 months ago by Charlie Reis
Modified:
4 years, 10 months ago
Reviewers:
Robert Sesek, nasko
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Diagnose renderer-side crash with browser-side stack trace. This will log a crash dump without crashing the browser process, letting us see how a main frame proxy is unexpectedly recreated. BUG=575245 TEST=Crash dumps in RenderFrameHostManager::InitRenderFrame. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/5f94df51c0c36b3099632f82970fc846840204ad Cr-Commit-Position: refs/heads/master@{#372772}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -1 line) Patch
M chrome/common/crash_keys.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager.cc View 2 chunks +29 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_impl.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1656603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1656603002/1
4 years, 10 months ago (2016-01-31 06:44:13 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-01-31 08:22:11 UTC) #5
Charlie Reis
Nasko: Can you take a look? Per comment 20 on https://crbug.com/575245, we're likely getting to ...
4 years, 10 months ago (2016-02-01 18:43:13 UTC) #7
Robert Sesek
lgtm
4 years, 10 months ago (2016-02-01 19:11:20 UTC) #8
nasko
LGTM
4 years, 10 months ago (2016-02-01 19:47:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1656603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1656603002/1
4 years, 10 months ago (2016-02-01 20:06:40 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-01 21:45:38 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-01 21:46:36 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5f94df51c0c36b3099632f82970fc846840204ad
Cr-Commit-Position: refs/heads/master@{#372772}

Powered by Google App Engine
This is Rietveld 408576698