Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 1656533002: Fix safepoint entering when waiting for a debugger task. (Closed)

Created:
4 years, 10 months ago by sof
Modified:
4 years, 10 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews, kinuko+worker_chromium.org, falken, blink-worker-reviews_chromium.org, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix safepoint entering when waiting for a debugger task. When attempting to run worker debugger tasks, a timed wait is made on the underlying task queue. While doing so, we are at a safepoint wrt Blink GCs for the worker, and enter a safepoint scope. The worker thread's stack will not be empty and clear of potential heap references at that point; enter the safepoint with an appropriate stack state. R= BUG=582710 Committed: https://crrev.com/137b56ddd5a272f4556ea2ff01bc7eba25866f5d Cr-Commit-Position: refs/heads/master@{#372570}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/workers/WorkerThread.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1656533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1656533002/1
4 years, 10 months ago (2016-01-30 19:56:20 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-01-30 21:08:24 UTC) #4
sof
please take a look. Oversight as part of moving away from WorkerRunLoop in https://codereview.chromium.org/423303004/
4 years, 10 months ago (2016-01-30 21:28:13 UTC) #6
haraken
LGTM
4 years, 10 months ago (2016-01-31 04:37:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1656533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1656533002/1
4 years, 10 months ago (2016-01-31 04:37:56 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-31 04:41:59 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-01-31 04:42:55 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/137b56ddd5a272f4556ea2ff01bc7eba25866f5d
Cr-Commit-Position: refs/heads/master@{#372570}

Powered by Google App Engine
This is Rietveld 408576698