chrome/browser/notifications/platform_notification_service_browsertest.cc - Issue 1656243002: Implementation of renotify flag for Notifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/platform_notification_service_browsertest.cc

Issue 1656243002: Implementation of renotify flag for Notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added TypeError for incorrect options and unit test Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/notification_ui_manager_android.cc ('k') | chrome/browser/notifications/platform_notification_service_impl.cc » ('j') | content/browser/notifications/notification_database_data.proto » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/platform_notification_service_browsertest.cc

diff --git a/chrome/browser/notifications/platform_notification_service_browsertest.cc b/chrome/browser/notifications/platform_notification_service_browsertest.cc

index b7a173c8498932753b330129570b7df3130d369a..a7913ac91f1e5a40a0769208621032ba02685fed 100644

--- a/chrome/browser/notifications/platform_notification_service_browsertest.cc

+++ b/chrome/browser/notifications/platform_notification_service_browsertest.cc

@@ -238,6 +238,7 @@ IN_PROC_BROWSER_TEST_F(PlatformNotificationServiceBrowserTest,

EXPECT_TRUE(default_notification.icon().IsEmpty());

EXPECT_FALSE(default_notification.silent());

EXPECT_FALSE(default_notification.never_timeout());

+ EXPECT_FALSE(default_notification.renotify());

// Verifies that the notification's default timestamp is set in the last 30

// seconds. This number has no significance, but it needs to be significantly

@@ -262,6 +263,7 @@ IN_PROC_BROWSER_TEST_F(PlatformNotificationServiceBrowserTest,

EXPECT_FALSE(all_options_notification.icon().IsEmpty());

EXPECT_TRUE(all_options_notification.silent());

EXPECT_TRUE(all_options_notification.never_timeout());

+ EXPECT_TRUE(all_options_notification.renotify());

EXPECT_DOUBLE_EQ(kNotificationTimestamp,

all_options_notification.timestamp().ToJsTime());