chrome/browser/notifications/notification_ui_manager_android.cc - Issue 1656243002: Implementation of renotify flag for Notifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/notification_ui_manager_android.cc

Issue 1656243002: Implementation of renotify flag for Notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added TypeError for incorrect options and unit test Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/notifications/notification_ui_manager_android.cc

diff --git a/chrome/browser/notifications/notification_ui_manager_android.cc b/chrome/browser/notifications/notification_ui_manager_android.cc

index 19626a3dbe4cb82ef0a8a534ab9036bcc583a412..8d583bf091a947802c90c9469a6edde4b67cffb2 100644

--- a/chrome/browser/notifications/notification_ui_manager_android.cc

+++ b/chrome/browser/notifications/notification_ui_manager_android.cc

@@ -154,7 +154,7 @@ void NotificationUIManagerAndroid::Add(const Notification& notification,

profile_id.obj(), profile->IsOffTheRecord(), tag.obj(), title.obj(),

body.obj(), icon.obj(), vibration_pattern.obj(),

notification.timestamp().ToJavaTime(), notification.silent(),

- action_titles.obj());

+ notification.renotify(), action_titles.obj());

regenerated_notification_infos_[persistent_notification_id] =

std::make_pair(origin_url.spec(), notification.tag());