Add UMA stats for AppCacheUpdateJob results.

Add UMA stats for AppCacheUpdateJob results.

BUG=343620
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251844

[michaeln, 2014-02-14 23:42:06]

https://codereview.chromium.org/165613002/diff/30001/webkit/browser/appcache/...
File webkit/browser/appcache/appcache_update_job.cc (right):

https://codereview.chromium.org/165613002/diff/30001/webkit/browser/appcache/...
webkit/browser/appcache/appcache_update_job.cc:707: DCHECK(fetcher->result() !=
UPDATE_OK);
i'll put this dcheck in HandleCacheFailure()

[jsbell, 2014-02-14 23:53:26]

Will need a histograms.xml update

lgtm to me so far

https://codereview.chromium.org/165613002/diff/30001/webkit/browser/appcache/...
File webkit/browser/appcache/appcache_update_job.h (right):

https://codereview.chromium.org/165613002/diff/30001/webkit/browser/appcache/...
webkit/browser/appcache/appcache_update_job.h:38: // Used for uma stats only for
now.
Should probably warn that values should only be appended.

[michaeln, 2014-02-14 23:58:47]

On 2014/02/14 23:53:26, jsbell wrote:
> Will need a histograms.xml update

we can do that separately though, and move them all the the public file while
doing so (the internal file is not in my git checkout)

> 
> lgtm to me so far
> 
>
https://codereview.chromium.org/165613002/diff/30001/webkit/browser/appcache/...
> File webkit/browser/appcache/appcache_update_job.h (right):
> 
>
https://codereview.chromium.org/165613002/diff/30001/webkit/browser/appcache/...
> webkit/browser/appcache/appcache_update_job.h:38: // Used for uma stats only
for
> now.
> Should probably warn that values should only be appended.

done (on next upload)

[michaeln, 2014-02-15 00:03:56]

https://codereview.chromium.org/165613002/diff/100001/webkit/browser/appcache...
File webkit/browser/appcache/appcache_histograms.cc (right):

https://codereview.chromium.org/165613002/diff/100001/webkit/browser/appcache...
webkit/browser/appcache/appcache_histograms.cc:38: const std::string suffix =
OriginToCustomHistogramSuffix(origin_url);
This is copy/pasted from what idb does for open results.

[jsbell, 2014-02-15 00:23:54]

lgtm

https://codereview.chromium.org/165613002/diff/100001/webkit/browser/appcache...
File webkit/browser/appcache/appcache_histograms.cc (right):

https://codereview.chromium.org/165613002/diff/100001/webkit/browser/appcache...
webkit/browser/appcache/appcache_histograms.cc:38: const std::string suffix =
OriginToCustomHistogramSuffix(origin_url);
On 2014/02/15 00:03:56, michaeln wrote:
> This is copy/pasted from what idb does for open results.

... which we swiped from HostToCustomHistogramSuffix in
content/renderer/render_thread_impl.cc

(Don't forget to add both variations to histograms.xml like we did at first)

https://codereview.chromium.org/165613002/diff/100001/webkit/browser/appcache...
webkit/browser/appcache/appcache_histograms.cc:56: 
Delete extra blank line

[michaeln, 2014-02-15 00:56:34]

thnx!

[michaeln, 2014-02-15 00:58:34]

The CQ bit was checked by michaeln@chromium.org

[commit-bot: I haz the power, 2014-02-15 01:14:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/michaeln@chromium.org/165613002/260001

[commit-bot: I haz the power, 2014-02-15 02:05:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-15 02:05:40]

Retried try job too often on mac_rel for step(s) content_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[michaeln, 2014-02-18 18:43:32]

The CQ bit was checked by michaeln@chromium.org

[commit-bot: I haz the power, 2014-02-18 18:46:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/michaeln@chromium.org/165613002/560001

[commit-bot: I haz the power, 2014-02-18 21:21:16]

Change committed as 251844