Add UMA stats for AppCacheUpdateJob results.

webkit/browser/appcache/appcache_update_job.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WEBKIT_BROWSER_APPCACHE_APPCACHE_UPDATE_JOB_H_
 #define WEBKIT_BROWSER_APPCACHE_APPCACHE_UPDATE_JOB_H_
 
 #include <deque>
 #include <map>
 #include <set>
@@ skipping 17 matching lines @@
 namespace appcache {
 
 class HostNotifier;
 
 // Application cache Update algorithm and state.
 class WEBKIT_STORAGE_BROWSER_EXPORT AppCacheUpdateJob
     : public AppCacheStorage::Delegate,
       public AppCacheHost::Observer,
       public AppCacheService::Observer {
  public:
+  // Used for uma stats only for now.

[jsbell, 2014/02/14 23:53:26]

Should probably warn that values should only be appended.

+  enum ResultType {
+    UPDATE_OK, DB_ERROR, DISKCACHE_ERROR, QUOTA_ERROR, REDIRECT_ERROR,
+    MANIFEST_ERROR, NETWORK_ERROR, SERVER_ERROR,
+    NUM_UPDATE_JOB_RESULT_TYPES
+  };
+
   AppCacheUpdateJob(AppCacheService* service, AppCacheGroup* group);
   virtual ~AppCacheUpdateJob();
 
   // Triggers the update process or adds more info if this update is already
   // in progress.
   void StartUpdate(AppCacheHost* host, const GURL& new_master_resource);
 
  private:
   friend class AppCacheUpdateJobTest;
   class URLFetcher;
@@ skipping 63 matching lines @@
     const std::string& manifest_data() const { return manifest_data_; }
     AppCacheResponseWriter* response_writer() const {
       return response_writer_.get();
     }
     void set_existing_response_headers(net::HttpResponseHeaders* headers) {
       existing_response_headers_ = headers;
     }
     void set_existing_entry(const AppCacheEntry& entry) {
       existing_entry_ = entry;
     }
+    ResultType result() const { return result_; }
 
    private:
     // URLRequest::Delegate overrides
     virtual void OnReceivedRedirect(net::URLRequest* request,
                                     const GURL& new_url,
                                     bool* defer_redirect) OVERRIDE;
     virtual void OnResponseStarted(net::URLRequest* request) OVERRIDE;
     virtual void OnReadCompleted(net::URLRequest* request,
                                  int bytes_read) OVERRIDE;
 
     void AddConditionalHeaders(const net::HttpResponseHeaders* headers);
     void OnWriteComplete(int result);
     void ReadResponseData();
     bool ConsumeResponseData(int bytes_read);
     void OnResponseCompleted();
     bool MaybeRetryRequest();
 
     GURL url_;
     AppCacheUpdateJob* job_;
     FetchType fetch_type_;
     int retry_503_attempts_;
     scoped_refptr<net::IOBuffer> buffer_;
     scoped_ptr<net::URLRequest> request_;
     AppCacheEntry existing_entry_;
     scoped_refptr<net::HttpResponseHeaders> existing_response_headers_;
     std::string manifest_data_;
+    ResultType result_;
     scoped_ptr<AppCacheResponseWriter> response_writer_;
   };  // class URLFetcher
 
   AppCacheResponseWriter* CreateResponseWriter();
 
   // Methods for AppCacheStorage::Delegate.
   virtual void OnResponseInfoLoaded(AppCacheResponseInfo* response_info,
                                     int64 response_id) OVERRIDE;
   virtual void OnGroupAndNewestCacheStored(AppCacheGroup* group,
                                            AppCache* newest_cache,
                                            bool success,
                                            bool would_exceed_quota) OVERRIDE;
   virtual void OnGroupMadeObsolete(AppCacheGroup* group, bool success) OVERRIDE;
 
   // Methods for AppCacheHost::Observer.
   virtual void OnCacheSelectionComplete(AppCacheHost* host) OVERRIDE {}  // N/A
   virtual void OnDestructionImminent(AppCacheHost* host) OVERRIDE;
 
   // Methods for AppCacheService::Observer.
   virtual void OnServiceReinitialized(
       AppCacheStorageReference* old_storage) OVERRIDE;
 
-  void HandleCacheFailure(const std::string& error_message);
+  void HandleCacheFailure(const std::string& error_message, ResultType result);
 
   void FetchManifest(bool is_first_fetch);
   void HandleManifestFetchCompleted(URLFetcher* fetcher);
   void ContinueHandleManifestFetchCompleted(bool changed);
 
   void HandleUrlFetchCompleted(URLFetcher* fetcher);
   void HandleMasterEntryFetchCompleted(URLFetcher* fetcher);
 
   void HandleManifestRefetchCompleted(URLFetcher* fetcher);
   void OnManifestInfoWriteComplete(int result);
@@ skipping 134 matching lines @@
   AppCacheStorage* storage_;
 
   FRIEND_TEST_ALL_PREFIXES(AppCacheGroupTest, QueueUpdate);
 
   DISALLOW_COPY_AND_ASSIGN(AppCacheUpdateJob);
 };
 
 }  // namespace appcache
 
 #endif  // WEBKIT_BROWSER_APPCACHE_APPCACHE_UPDATE_JOB_H_