Issue 1656083003: Adds the input method private API to allow the component IME extension to change the XKB layout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1656083003: Adds the input method private API to allow the component IME extension to change the XKB layout. (Closed)

Created:
4 years, 10 months ago by Shu Chen

Modified:
4 years, 10 months ago

Reviewers:

CC:
chromium-reviews, extensions-reviews_chromium.org, yusukes+watch_chromium.org, shuchen+watch_chromium.org, asvitkine+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, davemoore+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2623

Target Ref:
refs/pending/branch-heads/2623

Project:
chromium

Visibility:
Public.

More Reviews

Description

Adds the input method private API to allow the component IME extension to change the XKB layout. BUG=170601 Review URL: https://codereview.chromium.org/1608163002 Cr-Commit-Position: refs/heads/master@{#370410} (cherry picked from commit 78d3f5f503c1b39600995867935701f5183e785c) Committed: https://chromium.googlesource.com/chromium/src/+/a28c9adf4bc6159d8d6a930222dfc6cc9eeec6b7

Patch Set 1 #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+54 lines, -0 lines)			Patch
M	chrome/browser/chromeos/extensions/input_method_api.h	View	1 chunk	+17 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/input_method_api.cc	View	3 chunks	+17 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/api/input_method_private.json	View	1 chunk	+18 lines, -0 lines	0 comments	Download
M	extensions/browser/extension_function_histogram_value.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/metrics/histograms/histograms.xml	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Shu Chen

4 years, 10 months ago (2016-02-02 02:39:53 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a28c9adf4bc6159d8d6a930222dfc6cc9eeec6b7.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages