Adds the input method private API to allow the component IME extension to change the XKB layout.

Adds the input method private API to allow the component IME extension to change the XKB layout.

BUG=170601
Committed: https://crrev.com/78d3f5f503c1b39600995867935701f5183e785c
Cr-Commit-Position: refs/heads/master@{#370410}

[Shu Chen, 2016-01-20 07:58:29]

shuchen@chromium.org changed reviewers:
+ isherman@chromium.org, nona@chromium.org

[Shu Chen, 2016-01-20 07:58:30]

nona@ for input method private api.

isherman@ for histograms.

Thanks!

[Shu Chen, 2016-01-20 08:01:07]

The CQ bit was checked by shuchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-20 08:03:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1608163002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1608163002/20001

[Ilya Sherman, 2016-01-20 08:41:27]

histograms.xml lgtm

[Seigo Nonaka, 2016-01-20 09:12:47]

lgtm

https://codereview.chromium.org/1608163002/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/extensions/input_method_api.cc (right):

https://codereview.chromium.org/1608163002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/extensions/input_method_api.cc:210:
keyboard->SetCurrentKeyboardLayoutByName(params->xkb_name);
just FYI

Please be careful. The passed string will be used for constructing arguments of
the new process.

I think it is safe now since this API is private and the passed argument is
sanitized. Please don't expose this API to public as this is.

[Shu Chen, 2016-01-20 09:17:22]

https://codereview.chromium.org/1608163002/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/extensions/input_method_api.cc (right):

https://codereview.chromium.org/1608163002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/extensions/input_method_api.cc:210:
keyboard->SetCurrentKeyboardLayoutByName(params->xkb_name);
On 2016/01/20 09:12:47, Seigo Nonaka wrote:
> just FYI
> 
> Please be careful. The passed string will be used for constructing arguments
of
> the new process.
> 
> I think it is safe now since this API is private and the passed argument is
> sanitized. Please don't expose this API to public as this is.

Thanks for reminding. This API will remain private.

Btw, SetCurrentKeyboardLayoutByName() won't cause new process as X11 has been
removed from Chrome OS.

[commit-bot: I haz the power, 2016-01-20 09:48:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-20 09:48:11]

Dry run: This issue passed the CQ dry run.

[Shu Chen, 2016-01-20 14:26:29]

The CQ bit was checked by shuchen@chromium.org

[commit-bot: I haz the power, 2016-01-20 14:26:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1608163002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1608163002/20001

[commit-bot: I haz the power, 2016-01-20 14:32:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-20 14:32:07]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Shu Chen, 2016-01-20 14:35:03]

The CQ bit was checked by shuchen@chromium.org

[commit-bot: I haz the power, 2016-01-20 14:35:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1608163002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1608163002/20001

[commit-bot: I haz the power, 2016-01-20 14:41:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-20 14:41:03]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Shu Chen, 2016-01-20 14:46:53]

The CQ bit was checked by shuchen@chromium.org

[Shu Chen, 2016-01-20 14:46:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
isherman@chromium.org, nona@chromium.org
Link to the patchset: https://codereview.chromium.org/1608163002/#ps60001
(title: " ")

[commit-bot: I haz the power, 2016-01-20 14:47:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1608163002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1608163002/60001

[commit-bot: I haz the power, 2016-01-20 16:43:15]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-01-20 16:44:13]

Description was changed from

==========
Adds the input method private API to allow the component IME extension to change
the XKB layout.

BUG=170601
==========

to

==========
Adds the input method private API to allow the component IME extension to change
the XKB layout.

BUG=170601

Committed: https://crrev.com/78d3f5f503c1b39600995867935701f5183e785c
Cr-Commit-Position: refs/heads/master@{#370410}
==========

[commit-bot: I haz the power, 2016-01-20 16:44:14]

Patchset 4 (id:??) landed as
https://crrev.com/78d3f5f503c1b39600995867935701f5183e785c
Cr-Commit-Position: refs/heads/master@{#370410}