Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1655463002:
Roll Breakpad f85e852..60f99d4 (Closed)
|
Created:
4 years, 10 months ago by Lei Zhang Modified:
4 years, 10 months ago Reviewers:
Mark Mentovai CC:
chromium-reviews, David Yen Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRoll Breakpad f85e852..60f99d4
https://chromium.googlesource.com/breakpad/breakpad/src.git/+log/f85e852..60f99d4
BUG=563716
TBR=mark@chromium.org
Committed: https://crrev.com/e978ea2a23912ecdf1c9dbf5af64ba696c477324
Cr-Commit-Position: refs/heads/master@{#372495}
Patch Set 1 #Messages
Total messages: 18 (9 generated)
thestig@chromium.org changed reviewers: + mark@chromium.org
TBR
The CQ bit was checked by thestig@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1655463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1655463002/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
Description was changed from ========== Roll Breakpad f85e852..60f99d4 https://chromium.googlesource.com/breakpad/breakpad/src.git/+log/f85e852..60f... BUG=563716 TEST=bots ========== to ========== Roll Breakpad f85e852..60f99d4 https://chromium.googlesource.com/breakpad/breakpad/src.git/+log/f85e852..60f... BUG=563716 TBR=mark@chromium.org ==========
The CQ bit was checked by thestig@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1655463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1655463002/1
LGTM
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by thestig@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1655463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1655463002/1
Message was sent while issue was closed.
Description was changed from ========== Roll Breakpad f85e852..60f99d4 https://chromium.googlesource.com/breakpad/breakpad/src.git/+log/f85e852..60f... BUG=563716 TBR=mark@chromium.org ========== to ========== Roll Breakpad f85e852..60f99d4 https://chromium.googlesource.com/breakpad/breakpad/src.git/+log/f85e852..60f... BUG=563716 TBR=mark@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Roll Breakpad f85e852..60f99d4 https://chromium.googlesource.com/breakpad/breakpad/src.git/+log/f85e852..60f... BUG=563716 TBR=mark@chromium.org ========== to ========== Roll Breakpad f85e852..60f99d4 https://chromium.googlesource.com/breakpad/breakpad/src.git/+log/f85e852..60f... BUG=563716 TBR=mark@chromium.org Committed: https://crrev.com/e978ea2a23912ecdf1c9dbf5af64ba696c477324 Cr-Commit-Position: refs/heads/master@{#372495} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/e978ea2a23912ecdf1c9dbf5af64ba696c477324 Cr-Commit-Position: refs/heads/master@{#372495} |
